[GitHub] [ignite-3] lowka commented on a diff in pull request #2503: IGNITE-20077 Sql. Bump calcite version to 1.35.0

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #2503:
URL: https://github.com/apache/ignite-3/pull/2503#discussion_r1308871744


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorsFactory.java:
##########
@@ -284,9 +288,12 @@ public void add(RowT row) {
                 return;
             }
 
-            Object[] args = new Object[argList.size()];
-            for (int i = 0; i < argList.size(); i++) {
-                args[i] = handler.get(argList.get(i), row);
+            int params = literalAgg ? 1 : argList.size();
+
+            Object[] args = new Object[params];

Review Comment:
   We need an issue to clean up this code after the issue with RelJson serialization/de serialization is fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org