You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2015/07/21 03:14:47 UTC
Review Request 36630: DRILL-3503: Make PruneScanRule pluggable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36630/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Bugs: DRILL-3503
https://issues.apache.org/jira/browse/DRILL-3503
Repository: drill-git
Description
-------
Added an interface to abstract away partitioning scheme away from the partition pruning rule. Removed some of the redundant logic in PruneScanRule.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSPartitionpruningScheme.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java 127e70a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionPruningScheme.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionPruningScheme.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java daa7276
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/ParquetPruneScanRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java 5b5e4bc
Diff: https://reviews.apache.org/r/36630/diff/
Testing
-------
Thanks,
Mehant Baid
Re: Review Request 36630: DRILL-3503: Make PruneScanRule pluggable
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36630/#review93819
-----------------------------------------------------------
Ship it!
I had already reviewed the original changes. Reviewed the incremental ones and looks good.
- Aman Sinha
On July 31, 2015, 3:35 a.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36630/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 3:35 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3503
> https://issues.apache.org/jira/browse/DRILL-3503
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Added an interface to abstract away partitioning scheme away from the partition pruning rule. Removed some of the redundant logic in PruneScanRule.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java 8307dff
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSPartitionLocation.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java 9ad14b1
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java 127e70a
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionDescriptor.java 35fdae9
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionLocation.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java b83cedd
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java daa7276
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/ParquetPruneScanRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java 5b5e4bc
>
> Diff: https://reviews.apache.org/r/36630/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehant Baid
>
>
Re: Review Request 36630: DRILL-3503: Make PruneScanRule pluggable
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36630/
-----------------------------------------------------------
(Updated July 31, 2015, 3:35 a.m.)
Review request for drill and Aman Sinha.
Changes
-------
Rebased on latest master. Moved a change from the patch for 3121 here.
Bugs: DRILL-3503
https://issues.apache.org/jira/browse/DRILL-3503
Repository: drill-git
Description
-------
Added an interface to abstract away partitioning scheme away from the partition pruning rule. Removed some of the redundant logic in PruneScanRule.
Diffs (updated)
-----
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java 8307dff
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSPartitionLocation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java 9ad14b1
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java 127e70a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionDescriptor.java 35fdae9
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionLocation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java b83cedd
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java daa7276
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/ParquetPruneScanRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java 5b5e4bc
Diff: https://reviews.apache.org/r/36630/diff/
Testing
-------
Thanks,
Mehant Baid
Re: Review Request 36630: DRILL-3503: Make PruneScanRule pluggable
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36630/
-----------------------------------------------------------
(Updated July 25, 2015, 7:08 a.m.)
Review request for drill and Aman Sinha.
Bugs: DRILL-3503
https://issues.apache.org/jira/browse/DRILL-3503
Repository: drill-git
Description
-------
Added an interface to abstract away partitioning scheme away from the partition pruning rule. Removed some of the redundant logic in PruneScanRule.
Diffs (updated)
-----
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java 8307dff
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSPartitionLocation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java 9ad14b1
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java 127e70a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionDescriptor.java 35fdae9
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionLocation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java b83cedd
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java daa7276
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/ParquetPruneScanRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java 5b5e4bc
Diff: https://reviews.apache.org/r/36630/diff/
Testing
-------
Thanks,
Mehant Baid
Re: Review Request 36630: DRILL-3503: Make PruneScanRule pluggable
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36630/
-----------------------------------------------------------
(Updated July 25, 2015, 6:18 a.m.)
Review request for drill and Aman Sinha.
Changes
-------
Made a few changes to the partition pruning interface.
Bugs: DRILL-3503
https://issues.apache.org/jira/browse/DRILL-3503
Repository: drill-git
Description
-------
Added an interface to abstract away partitioning scheme away from the partition pruning rule. Removed some of the redundant logic in PruneScanRule.
Diffs (updated)
-----
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java 8307dff
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSPartitionLocation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java 9ad14b1
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java 127e70a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionDescriptor.java 35fdae9
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionLocation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java b83cedd
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java daa7276
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/ParquetPruneScanRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java 5b5e4bc
Diff: https://reviews.apache.org/r/36630/diff/
Testing
-------
Thanks,
Mehant Baid
Re: Review Request 36630: DRILL-3503: Make PruneScanRule pluggable
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36630/#review92444
-----------------------------------------------------------
Ship it!
Having the new interface that is implemented by DFS and Parquet pruning (and in future Hive pruning) seems good to me.
- Aman Sinha
On July 21, 2015, 1:14 a.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36630/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 1:14 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3503
> https://issues.apache.org/jira/browse/DRILL-3503
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Added an interface to abstract away partitioning scheme away from the partition pruning rule. Removed some of the redundant logic in PruneScanRule.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSPartitionpruningScheme.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java 127e70a
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionPruningScheme.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionPruningScheme.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java daa7276
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/ParquetPruneScanRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java 5b5e4bc
>
> Diff: https://reviews.apache.org/r/36630/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehant Baid
>
>