You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/25 04:43:37 UTC

[GitHub] [pulsar] BewareMyPower commented on issue #8128: [cpp-tests] CI test BatchMessageTest.testIndividualAck is unstable and fails frequently on many PRs

BewareMyPower commented on issue #8128:
URL: https://github.com/apache/pulsar/issues/8128#issuecomment-698716763


   Maybe it's because that `gtest-parallel` runs tests using multiple threads. In `BatchMessageTest.cc`, `globalTestBatchMessagesCounter` is a global variable that's updated in `sendCallback`, while `sendCallBack` is used my multiple test suites.
   
   Many tests in `BatchMessageTest` is too old, at that time the cpp client's standard is 98/03. I think the message count and send callback should be replaced by a local variable and lambda expression to achieve data isolation between threads.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org