You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/01/04 20:08:20 UTC
svn commit: r1872322 - in
/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger:
PDFDebugger.java colorpane/CSDeviceN.java colorpane/CSIndexed.java
colorpane/CSSeparation.java
Author: tilman
Date: Sat Jan 4 20:08:20 2020
New Revision: 1872322
URL: http://svn.apache.org/viewvc?rev=1872322&view=rev
Log:
PDFBOX-2941: avoid throwing RuntimeException; improve javadoc; make fields final
Modified:
pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java
pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSIndexed.java
pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSSeparation.java
Modified: pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java?rev=1872322&r1=1872321&r2=1872322&view=diff
==============================================================================
--- pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java (original)
+++ pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java Sat Jan 4 20:08:20 2020
@@ -852,7 +852,7 @@ public class PDFDebugger extends JFrame
* Show a Panel describing color spaces in more detail and interactive way.
* @param csNode the special color space containing node.
*/
- private void showColorPane(Object csNode)
+ private void showColorPane(Object csNode) throws IOException
{
csNode = getUnderneathObject(csNode);
Modified: pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java?rev=1872322&r1=1872321&r2=1872322&view=diff
==============================================================================
--- pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java (original)
+++ pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java Sat Jan 4 20:08:20 2020
@@ -31,36 +31,27 @@ import java.io.IOException;
import org.apache.pdfbox.cos.COSArray;
import org.apache.pdfbox.pdmodel.graphics.color.PDDeviceN;
-
-/**
- *@author Khyrul Bashar.
- */
-
/**
* A class that provides the necessary UI and functionalities to show the DeviceN color space.
+ *
+ * @author Khyrul Bashar.
+ *
*/
public class CSDeviceN
{
- private PDDeviceN deviceN;
+ private final PDDeviceN deviceN;
private JPanel panel;
/**
* Constructor
*
- * @param array COSArray instance that holds DeviceN color space
+ * @param array COSArray instance that holds the DeviceN color space
*/
- public CSDeviceN(COSArray array)
+ public CSDeviceN(COSArray array) throws IOException
{
- try
- {
- deviceN = new PDDeviceN(array);
- DeviceNColorant[] colorants = getColorantData();
- initUI(colorants);
- }
- catch (IOException e)
- {
- throw new RuntimeException(e);
- }
+ deviceN = new PDDeviceN(array);
+ DeviceNColorant[] colorants = getColorantData();
+ initUI(colorants);
}
/**
Modified: pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSIndexed.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSIndexed.java?rev=1872322&r1=1872321&r2=1872322&view=diff
==============================================================================
--- pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSIndexed.java (original)
+++ pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSIndexed.java Sat Jan 4 20:08:20 2020
@@ -34,34 +34,26 @@ import org.apache.pdfbox.cos.COSNumber;
import org.apache.pdfbox.pdmodel.graphics.color.PDIndexed;
/**
- * @author Khyrul Bashar.
- */
-
-/**
* A class that provides the necessary UI and functionalities to show the Indexed colorspace.
+ *
+ * @author Khyrul Bashar.
*/
public class CSIndexed
{
- private PDIndexed indexed;
+ private final PDIndexed indexed;
private JPanel panel;
- private int colorCount;
+ private final int colorCount;
/**
* Constructor.
- * @param array COSArray instance for Indexed Colorspace.
+ * @param array COSArray instance for Indexed color space.
+ * @throws java.io.IOException
*/
- public CSIndexed(COSArray array)
+ public CSIndexed(COSArray array) throws IOException
{
- try
- {
- indexed = new PDIndexed(array);
- colorCount = getHival(array) + 1;
- initUI(getColorantData());
- }
- catch (IOException e)
- {
- throw new RuntimeException(e);
- }
+ indexed = new PDIndexed(array);
+ colorCount = getHival(array) + 1;
+ initUI(getColorantData());
}
/**
Modified: pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSSeparation.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSSeparation.java?rev=1872322&r1=1872321&r2=1872322&view=diff
==============================================================================
--- pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSSeparation.java (original)
+++ pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSSeparation.java Sat Jan 4 20:08:20 2020
@@ -40,12 +40,10 @@ import org.apache.pdfbox.cos.COSArray;
import org.apache.pdfbox.pdmodel.graphics.color.PDSeparation;
/**
+ * A class that provides the necessary UI and functionalities to show the Separation color space.
+ *
* @author Khyrul Bashar.
*/
-
-/**
- *A class that provides the necessary UI and functionalities to show the Separation color space.
- */
public class CSSeparation implements ChangeListener, ActionListener
{
private JSlider slider;
@@ -53,23 +51,19 @@ public class CSSeparation implements Cha
private JLabel colorBar;
private JPanel panel;
- private PDSeparation separation;
+ private final PDSeparation separation;
private float tintValue = 1;
/**
* Constructor
- * @param array COSArray instance of the separation color space.
+ *
+ * @param array COSArray instance of the Separation color space.
+ *
+ * @throws java.io.IOException
*/
- public CSSeparation(COSArray array)
+ public CSSeparation(COSArray array) throws IOException
{
- try
- {
- separation = new PDSeparation(array);
- }
- catch (IOException e)
- {
- throw new RuntimeException(e);
- }
+ separation = new PDSeparation(array);
initUI();
initValues();
}