You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mike Sokolov (JIRA)" <ji...@apache.org> on 2018/05/18 11:59:00 UTC
[jira] [Commented] (LUCENE-8319) A Time-limiting collector that
works with CollectorManagers
[ https://issues.apache.org/jira/browse/LUCENE-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480548#comment-16480548 ]
Mike Sokolov commented on LUCENE-8319:
--------------------------------------
I wonder if we could have TimeExceeededException extend CollectionTerminatedException -- if that fixes the issue, it would be a pretty small change, and I don't think there are any cases where you would want to catch CTE and *not catch* TEE ?
> A Time-limiting collector that works with CollectorManagers
> -----------------------------------------------------------
>
> Key: LUCENE-8319
> URL: https://issues.apache.org/jira/browse/LUCENE-8319
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Tony Xu
> Priority: Minor
>
> Currently Lucene has *TimeLimitingCollector* to support time-bound collection and it will throw
> *TimeExceededException* if timeout happens. This only works nicely with the single-thread low-level API from the IndexSearcher. The method signature is --
> *void search(List<LeafReaderContext> leaves, Weight weight, Collector collector)*
> The intended use is to always enclose the searcher.search(query, collector) call with a try ... catch and handle the timeout exception. Unfortunately when working with a *CollectorManager* in the multi-thread search context, the *TimeExceededException* thrown during collecting one leaf slice will be re-thrown by *IndexSearcher* without calling *CollectorManager*'s reduce(), even if other slices are successfully collected. The signature
> of the search api with *CollectorManager* is --
> *<C extends Collector, T> T search(Query query, CollectorManager<C, T> collectorManager)*
>
> The good news is that IndexSearcher handles *CollectionTerminatedException* gracefully by ignoring it. We can either wrap TimeLimitingCollector and throw *CollectionTerminatedException* when timeout happens or simply replace *TimeExceededException* with *CollectionTerminatedException*. In either way, we also need to maintain a flag that indicates if timeout occurred so that the user know it's a partial collection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org