[GitHub] [superset] hughhhh commented on pull request #22581: bug(ssh-tunnel): fix dataset creation flow through modal for DB with tunnel

[GitBox <gi...@apache.org>]

hughhhh commented on PR #22581:
URL: https://github.com/apache/superset/pull/22581#issuecomment-1371379136

   > @hughhhh I think we should try to avoid this intrusive coding style, this context function has modified too much logic, you should redesign this function.
   
   why do you think it's intrusive?
   
   This pattern is the cleanest way for us to support ssh tunnel in my opinion since we have to build the tunnel within context for any request to query the db


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org