You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/01 15:37:26 UTC
[GitHub] [skywalking] codecov-io edited a comment on issue #4353: Optimizing
performance reduces es index queries scope by timebucket
codecov-io edited a comment on issue #4353: Optimizing performance reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#issuecomment-585057389
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr&el=h1) Report
> Merging [#4353](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/04f28549276262a55fd3493ea9c6f785bfc0986e?src=pr&el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4353 +/- ##
==========================================
- Coverage 25.4% 24.95% -0.45%
==========================================
Files 1212 1214 +2
Lines 28082 28246 +164
Branches 3883 3899 +16
==========================================
- Hits 7134 7049 -85
- Misses 20297 20548 +251
+ Partials 651 649 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...re/register/service/EndpointInventoryRegister.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVnaXN0ZXIvc2VydmljZS9FbmRwb2ludEludmVudG9yeVJlZ2lzdGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...lking/oap/query/graphql/resolver/ProfileQuery.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL1Byb2ZpbGVRdWVyeS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [.../oap/server/core/query/entity/ProfiledSegment.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvZW50aXR5L1Byb2ZpbGVkU2VnbWVudC5qYXZh) | `0% <0%> (ø)` | |
| [...oap/server/core/query/ProfileTaskQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...storage/plugin/jdbc/h2/dao/H2TopologyQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVG9wb2xvZ3lRdWVyeURBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ng/oap/server/core/query/TopologyQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVG9wb2xvZ3lRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...ing/oap/server/core/query/entity/ProfiledSpan.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvZW50aXR5L1Byb2ZpbGVkU3Bhbi5qYXZh) | `0% <0%> (ø)` | |
| [...r/parser/standardization/ReferenceIdExchanger.java](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9SZWZlcmVuY2VJZEV4Y2hhbmdlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/4353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr&el=footer). Last update [04f2854...5fd4dff](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services