You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/09 17:16:10 UTC

[GitHub] [flink] StephanEwen commented on issue #8846: [FLINK-12766][runtime] Dynamically allocate TaskExecutor's managed memory to slots.

StephanEwen commented on issue #8846: [FLINK-12766][runtime] Dynamically allocate TaskExecutor's managed memory to slots.
URL: https://github.com/apache/flink/pull/8846#issuecomment-509729439
 
 
   I am currently going through this PR.
   
   About the changes to the `ResourceProfile`:
     - The code could use some tests
     - The code seems to assume that all values are non-negative, but the constructor does not actually enforce this. What do you think about adding checks to the constructor and using a private constructor for the UNKNOWN profile (which needs negative values)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services