You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/19 22:30:29 UTC

[GitHub] [tvm] tkonolige opened a new pull request #7709: [FIX] Fix temporary allocation size in threefry

tkonolige opened a new pull request #7709:
URL: https://github.com/apache/tvm/pull/7709


   Fixes #7682.
   
   Not sure why the tests didn't hit this error case. Maybe they didn't try a large enough size to blow the heap?
   
   @altanh @MarisaKirisame 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7709: [FIX] Fix temporary allocation size in threefry

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7709:
URL: https://github.com/apache/tvm/pull/7709#issuecomment-803175187


   Also cc @XIAO-XIA @yzhliu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #7709: [FIX] Fix temporary allocation size in threefry

Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #7709:
URL: https://github.com/apache/tvm/pull/7709#issuecomment-804196450


   I guess I could bump the test sizes, not sure what size it requires to error out though. We really need a way to check for out of bound memory access in tir.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] MarisaKirisame merged pull request #7709: [FIX] Fix temporary allocation size in threefry

Posted by GitBox <gi...@apache.org>.
MarisaKirisame merged pull request #7709:
URL: https://github.com/apache/tvm/pull/7709


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] MarisaKirisame commented on pull request #7709: [FIX] Fix temporary allocation size in threefry

Posted by GitBox <gi...@apache.org>.
MarisaKirisame commented on pull request #7709:
URL: https://github.com/apache/tvm/pull/7709#issuecomment-803458419


   lgtm. can you add a regression test to make sure it wont happend again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org