[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r401267437
 
 

 ##########
 File path: gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlStateStore.java
 ##########
 @@ -73,7 +74,7 @@
  *
  * @param <T> state object type
  **/
-public class MysqlStateStore<T extends State> implements StateStore<T> {
+public class MysqlStateStore<T extends State> implements StateStore<T>, DatasetStateStore<T> {
 
 Review comment:
   This is looking strange. The child class MySqlDatasetStateStore extends MySqlStateStore and implements DatasetStateStore. And the parent class is implementing the interface. See my comment earlier about considering the possibility of MysqlJobStatusStore extending MySqlDatasetStateStore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services