You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/22 09:07:29 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #5149: [AIRFLOW-4356] Add extra RuntimeEnvironment keys to DataFlowHook

potiuk commented on a change in pull request #5149: [AIRFLOW-4356] Add extra RuntimeEnvironment keys to DataFlowHook
URL: https://github.com/apache/airflow/pull/5149#discussion_r277244177
 
 

 ##########
 File path: tests/contrib/hooks/test_gcp_dataflow_hook.py
 ##########
 @@ -51,6 +51,22 @@
     'tempLocation': 'gs://test/temp',
     'zone': 'us-central1-f'
 }
+RUNTIME_ENV = {
 
 Review comment:
   I think you missed some modifications in the tests - RUNTIME_ENV is not used :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services