[jira] [Commented] (PHOENIX-5984) Query timeout counter is not updated in all timeouts cases

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149871#comment-17149871 ] 

Hadoop QA commented on PHOENIX-5984:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13006874/PHOENIX-5984-4.x-v1.patch
  against 4.x branch at commit 713c8d953596f7a002502b7298a393414766a87e.
  ATTACHMENT ID: 13006874

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4011//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4011//artifact/phoenix-core/target/site/jacoco/index.html
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4011//console

This message is automatically generated.

> Query timeout counter is not updated in all timeouts cases
> ----------------------------------------------------------
>
>                 Key: PHOENIX-5984
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5984
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0
>            Reporter: Chinmay Kulkarni
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>              Labels: metrics, phoenix-hardening, quality-improvement
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-5984-4.x-v1.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The OverallQueryMetrics query timeout counter and global query timeout counter are not updated if the query times out before getting the future corresponding to the scan i.e. if it times out at [this point| https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1299-L1301].
> We only update relevant metrics if we catch a TimeoutException [here|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1361] if the future.get times out [here|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1312]. We should update the metrics in the first case as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)