[GitHub] [flink] echauchot commented on a diff in pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts

[GitBox <gi...@apache.org>]

echauchot commented on code in PR #20184:
URL: https://github.com/apache/flink/pull/20184#discussion_r916606194


##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:
##########
@@ -458,7 +464,10 @@ protected Tuple3<String, Integer, Integer> generateValue(int counter, int checkp
     protected void verifyResultsIdealCircumstances(
             CassandraTupleWriteAheadSink<Tuple3<String, Integer, Integer>> sink) {
 
-        ResultSet result = session.execute(injectTableName(SELECT_DATA_QUERY));
+        ResultSet result =
+                session.execute(
+                        new SimpleStatement(injectTableName(SELECT_DATA_QUERY))
+                                .setReadTimeoutMillis(READ_TIMEOUT_MILLIS));

Review Comment:
   Yes but as I wrote in the ticket: 
   
   >  "the driver timeouts were set on the clusterBuilder because previous timeout errors were only on test cases. Here, the request timeouts are on session.execute that do not use the ClusterBuilder. Thus, they use the default 12s timeout. I'll raise to 36s per session request."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org