[GitHub] brodybits commented on a change in pull request #213: Platform release with npm test instead of extra unit tests

[GitBox <gi...@apache.org>]

brodybits commented on a change in pull request #213: Platform release with npm test instead of extra unit tests
URL: https://github.com/apache/cordova-coho/pull/213#discussion_r237121423
 
 

 ##########
 File path: docs/platforms-release-process.md
 ##########
 @@ -261,6 +262,10 @@ Then ensure commits look okay on both branches
 
 Once all the repos are branched, we focus on testing & fixing all of the regressions we find.
 
+### Prerequisite: npm test
+
+Ensure that `npm test` succeeds. This can normally be done by checking for a green build.
 
 Review comment:
   Reworded, got rid of "normally", and added info that we are waiting for <https://github.com/apache/cordova-osx/issues/71> to be resolved.
   
   I generally run unit tests on my local machine. To run the full `npm test` suite often takes much longer on my local machine than on Travis CI. I think having a green build on CI is much more important than verifying it locally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org