You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2009/01/27 11:01:32 UTC
Re: svn commit: r35480 -
branches/http-protocol-v2/subversion/libsvn_ra_serf
On Mon, Jan 26, 2009 at 22:03, C. Michael Pilato <cm...@collab.net> wrote:
>...
> +++ branches/http-protocol-v2/subversion/libsvn_ra_serf/property.c Mon Jan 26 13:03:28 2009 (r35480)
>...
> @@ -977,6 +956,32 @@ svn_ra_serf__get_baseline_info(const cha
> *bc_relative = svn_path_is_child(decoded_root, decoded_url, pool);
> SVN_ERR_ASSERT(*bc_relative != NULL);
> }
> +
> + if (latest_revnum)
> + {
> + svn_ra_serf__options_context_t *opt_ctx;
> + svn_error_t *err;
> +
> + svn_ra_serf__create_options_req(&opt_ctx, session, session->conns[0],
> + session->repos_url.path, pool);
> + err = svn_ra_serf__context_run_wait
> + (svn_ra_serf__get_options_done_ptr(opt_ctx), session, pool);
Remove the whitespace before the open-paren.
>...
> +++ branches/http-protocol-v2/subversion/libsvn_ra_serf/ra_serf.h Mon Jan 26 13:03:28 2009 (r35480)
>...
> +#define SVN_RA_SERF__HAVE_HTTPV2_SUPPORT(sess) (sess->me_resource != NULL)
Should protect the SESS variable better:
((sess)->me_resource != NULL)
>...
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1058496
Re: svn commit: r35480 -
branches/http-protocol-v2/subversion/libsvn_ra_serf
Posted by "C. Michael Pilato" <cm...@collab.net>.
Greg Stein wrote:
> On Mon, Jan 26, 2009 at 22:03, C. Michael Pilato <cm...@collab.net> wrote:
>> ...
>> +++ branches/http-protocol-v2/subversion/libsvn_ra_serf/property.c Mon Jan 26 13:03:28 2009 (r35480)
>> ...
>> @@ -977,6 +956,32 @@ svn_ra_serf__get_baseline_info(const cha
>> *bc_relative = svn_path_is_child(decoded_root, decoded_url, pool);
>> SVN_ERR_ASSERT(*bc_relative != NULL);
>> }
>> +
>> + if (latest_revnum)
>> + {
>> + svn_ra_serf__options_context_t *opt_ctx;
>> + svn_error_t *err;
>> +
>> + svn_ra_serf__create_options_req(&opt_ctx, session, session->conns[0],
>> + session->repos_url.path, pool);
>> + err = svn_ra_serf__context_run_wait
>> + (svn_ra_serf__get_options_done_ptr(opt_ctx), session, pool);
>
> Remove the whitespace before the open-paren.
>
>> ...
>> +++ branches/http-protocol-v2/subversion/libsvn_ra_serf/ra_serf.h Mon Jan 26 13:03:28 2009 (r35480)
>> ...
>> +#define SVN_RA_SERF__HAVE_HTTPV2_SUPPORT(sess) (sess->me_resource != NULL)
>
> Should protect the SESS variable better:
>
> ((sess)->me_resource != NULL)
r35489. Thanks.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1058933