[jira] Commented: (MECLIPSE-486) ITs dont compare expected files if the IT is a multi-module project

["Barrie Treloar (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MECLIPSE-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=147723#action_147723 ] 

Barrie Treloar commented on MECLIPSE-486:
-----------------------------------------

{noformat}
pom.xml:
	Fixed the phase "test" to not include "projects/**" as this directory is copied from src/test/resources into target/test-classes
	and surefire will attempt to compile any *Test*.java files - which will fail since they are not in the correct location
	relative to their package declaration.  See http://www.nabble.com/Plugins%3A-execution-configuration-does-not-add-to-configuration-td19425025.html

	Fixed the run-its profile so that it overrides the excludes inherited from the "test" phase configuration.

IdeUtils: 
	Refactored code to create fixSeparator() method.

AbstractEclipsePluginIT: 
	Changed compareDirectoryContent to no longer accept a directory to use as check contents.
	Instead ${basedir} is searched for EXPECTED_DIRECTORY_NAME ("expected") and all occurrences
	of this directory are used in the comparison processes. This has simplified checking in
	code as you no longer need to specify additional calls for multiple directories and
	made it easier to support multi-module checking as previously only ${basedir}/expected
	was checked, module directories where ignored. The actual files checked are relative to the 
	parent directory of the matching "expected" directory.

	IOExceptions are no longer thrown instead MojoExecutionException are used mainly by 
	delegating to IdeUtils.getCanonicalPath() instead of calling File.getCanonicalPath() directly.

RadPluginIT:
	Updated to use new compareDirectoryContent()

src/test/resources/projects/*:
	Fixed files that were never previously checked to use the contents of the actual 
	maven-eclipse-plugin output. On the assumption that the plugin is generating the correct
	output and nothing in this change set has altered that behaviour.
{noformat}

> ITs dont compare expected files if the IT is a multi-module project
> -------------------------------------------------------------------
>
>                 Key: MECLIPSE-486
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-486
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: Core : Multi-projects
>    Affects Versions: 2.6
>            Reporter: Barrie Treloar
>            Assignee: Barrie Treloar
>
> The comparison of directories is only done in testProject:
> {code:title=AbstractEclipsePluginIT.testProject(String, Properties, String, String)}
> // line 250
>         compareDirectoryContent( basedir, projectOutputDir, "" );
>         compareDirectoryContent( basedir, projectOutputDir, ".settings/" );
>         compareDirectoryContent( basedir, projectOutputDir, ".externalToolBuilders/" );
>         compareDirectoryContent( basedir, projectOutputDir, "META-INF/" );
> {code}
> which only checks the top level basedir.
> I'm changing the tests to locate all "expected" directories under basedir and to compare all the files recursively under "expected" to the equivalent level in the outputDir.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira