[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3882: simplify unqualified col name aliases

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3882:
URL: https://github.com/apache/arrow-datafusion/pull/3882#discussion_r999898918


##########
datafusion/core/tests/sql/select.rs:
##########
@@ -505,14 +505,14 @@ async fn use_between_expression_in_select_query() -> Result<()> {
     let actual = execute_to_batches(&ctx, sql).await;
     // Expect field name to be correctly converted for expr, low and high.
     let expected = vec![
-        "+-------------------------------------------------------------+",
-        "| abs(test.c1) BETWEEN Int64(0) AND log(test.c1 * Int64(100)) |",
-        "+-------------------------------------------------------------+",
-        "| true                                                        |",
-        "| true                                                        |",
-        "| false                                                       |",
-        "| false                                                       |",
-        "+-------------------------------------------------------------+",
+        "+------------------------------+",

Review Comment:
   The plan changes sure look nicer 😍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org