You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/16 08:00:51 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
MaxGekk opened a new pull request #31571:
URL: https://github.com/apache/spark/pull/31571
### What changes were proposed in this pull request?
Remove `.internal()` from the SQL config legacy config `spark.sql.legacy.replaceDatabricksSparkAvro.enabled`.
### Why are the changes needed?
In fact, the SQL config `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` has been already documented publicly, see http://spark.apache.org/docs/latest/sql-data-sources-avro.html. So, it can be considered as internal config.
### Does this PR introduce _any_ user-facing change?
This updates the list of auto generated SQL configs.
### How was this patch tested?
By generating docs:
```
$ ./sql/create-docs.sh
$ cd docs
$ SKIP_API=1 SKIP_SCALADOC=1 SKIP_PYTHONDOC=1 SKIP_RDOC=1 jekyll serve --watch
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-781035490
@MaxGekk . Shall we close this PR because we have #31577 and #31578 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779660488
@HyukjinKwon @gengliangwang @cloud-fan Could you take a look at this, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk edited a comment on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779658999
There are other legacy configs that are non-internal:
- spark.sql.legacy.allowHashOnMapType
- spark.sql.legacy.sessionInitWithConfigDefaults
Though I am not sure why the configs ^^ are not internal, maybe there is a mistake because the configs are not mentioned in public docs. @HyukjinKwon WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31571:
URL: https://github.com/apache/spark/pull/31571#discussion_r577733073
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2505,7 +2505,6 @@ object SQLConf {
val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Review comment:
Let's deprecate it and then remove it in later versions. It's OK if a deprecated internal config is mentioned in public docs for migration purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31571:
URL: https://github.com/apache/spark/pull/31571#discussion_r577267118
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2505,7 +2505,6 @@ object SQLConf {
val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Review comment:
@gengliangwang do we need this conf? We do the same thing in `com.databricks.spark.csv` already by default internally. We could just make it exposed and deprecate this config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-781077378
Since #31578 is merged, I'll close this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31571:
URL: https://github.com/apache/spark/pull/31571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779658999
There are other legacy configs that are non-internal:
- spark.sql.legacy.allowHashOnMapType
- spark.sql.legacy.sessionInitWithConfigDefaults
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31571:
URL: https://github.com/apache/spark/pull/31571#discussion_r577267275
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2505,7 +2505,6 @@ object SQLConf {
val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Review comment:
In this way, I think it will address most of concerns raised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31571:
URL: https://github.com/apache/spark/pull/31571#discussion_r577267118
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2505,7 +2505,6 @@ object SQLConf {
val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Review comment:
@gengliangwang do we need this conf? We do the same thing in `com.databricks.spark.csv` already by default internally. We could just make it exposed and deprecate (remove?) this config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779718643
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39750/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-780179070
No, I don't. `Removing a config w/o deprecation` sounds wrong.
> Do you consider a situation when you can just remove this config w/o deprecation only because it is marked as .internal()?
No. I disagree with the expression, `de facto`. The documentation change is far much easier than removing `non-internal` config.
> it is external de facto.
Like https://github.com/databricks/spark-avro says, only `Databricks customer` can use this library directly . All other distributions, especially 3.2.0+ versions, I don't think this PR makes sense.
> Databricks customers can also use this library directly on the Databricks Unified Analytics Platform without any additional dependency configurations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-780017986
> Given that this was there since 2.4.0, I'm not sure why Apache Spark 3.2.0 does require this suddenly.
FYI, I have found this config while documenting other "internal" configs, see https://github.com/apache/spark/pull/31564#pullrequestreview-590877832
> I'm a little reluctant to advertise this option more explicitly in Apache Spark side.
It has been already explicitly advertised in public docs:
http://spark.apache.org/docs/latest/sql-data-sources-avro.html#compatibility-with-databricks-spark-avro
http://spark.apache.org/docs/latest/sql-data-sources-avro.html#configuration
> This additional exposure proposal puts us into a more difficult situation when we want to remove this completely in the future from the Apache Spark codebase.
Do you consider a situation when you can just remove this config w/o deprecation only because it is marked as `.internal()`?
From my point of view, even the config is "internal" de jure, it is external de facto. In this situation, it cannot be just removed hiddenly from users. I do believe we should make it as external de jure, so, maybe remove it in the future only via deprecation otherwise we can break users apps potentially. @HyukjinKwon @cloud-fan WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31571:
URL: https://github.com/apache/spark/pull/31571#discussion_r577846296
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2505,7 +2505,6 @@ object SQLConf {
val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Review comment:
Here is the PR https://github.com/apache/spark/pull/31578 to deprecate the config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31571:
URL: https://github.com/apache/spark/pull/31571#discussion_r577986218
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2505,7 +2505,6 @@ object SQLConf {
val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Review comment:
Thank you all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-780659014
> There are other legacy configs that are non-internal:
All legacy configs should be internal. These 2 are very likely mistakes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31571:
URL: https://github.com/apache/spark/pull/31571#discussion_r577269016
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2505,7 +2505,6 @@ object SQLConf {
val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Review comment:
And then we could remove both `com.databricks.spark.csv` and `com.databricks.spark.avro` fallbacks together in the future, of course (Spark 4.0?). I don't think it makes sense to keep both mapping forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779718643
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39750/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-780179070
No, I don't. `Removing a config w/o deprecation` sounds wrong.
> Do you consider a situation when you can just remove this config w/o deprecation only because it is marked as .internal()?
No. I disagree with the expression, `de facto`. The documentation change is far much easier than removing `non-internal` config.
> it is external de facto.
Like https://github.com/databricks/spark-avro says, only `Databricks customer` can use that library directly . All other distributions, especially 3.2.0+ versions, I don't think this PR makes sense.
> Databricks customers can also use this library directly on the Databricks Unified Analytics Platform without any additional dependency configurations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-780732021
> All legacy configs should be internal. These 2 are very likely mistakes.
We have already marked all legacy configs as internal configs before the release 3.0, see https://github.com/apache/spark/pull/27448 . Those 2 configs were added after the commit, probably.
I opened the PR https://github.com/apache/spark/pull/31577 with a test which checks that all legacy SQL configs are internal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779724813
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135169/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779666053
**[Test build #135169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135169/testReport)** for PR 31571 at commit [`c43224e`](https://github.com/apache/spark/commit/c43224e894971ac9e500a0d59b1715f8f922caff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-779724813
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135169/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org