You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2020/05/08 19:30:09 UTC

[GitHub] [bigtop] evans-ye commented on a change in pull request #634: BIGTOP-3343. Add Debian 10 and Ubuntu 18.04 support to the Docker provisioner.

evans-ye commented on a change in pull request #634:
URL: https://github.com/apache/bigtop/pull/634#discussion_r422330723



##########
File path: bigtop-deploy/puppet/manifests/bigtop_repo.pp
##########
@@ -43,9 +43,10 @@
       # I couldn't enforce the sequence -> anymore because of this
       # https://twitter.com/c0sin/status/875869783979196416
        apt::conf { "disable_keys":
-          content => "APT::Get::AllowUnauthenticated 1;",
+          content => "APT::Get::AllowUnauthenticated 1;\nAcquire::AllowInsecureRepositories \"true\";",

Review comment:
       @elukey I did some trace and it was originally added in:
   https://issues.apache.org/jira/browse/BIGTOP-1676
   I'm the author. I guess that's for testing purpose. Anyhow it seems not secure as what you're concerning. We should make it default to secure mode and disable if needed in test.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org