You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/12 03:44:28 UTC
[GitHub] [rocketmq-spring] RongtongJin opened a new pull request, #510: Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
RongtongJin opened a new pull request, #510:
URL: https://github.com/apache/rocketmq-spring/pull/510
## What is the purpose of the change
Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
## Brief changelog
Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-spring] francisoliverlee commented on a diff in pull request #510: [ISSUE #511] Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on code in PR #510:
URL: https://github.com/apache/rocketmq-spring/pull/510#discussion_r1067722623
##########
rocketmq-spring-boot-samples/rocketmq-consume-acl-demo/src/main/resources/application.properties:
##########
@@ -16,13 +16,15 @@
spring.application.name=rocketmq-consume-acl-demo
-rocketmq.name-server=Endpoint_of_Aliware_MQ
-rocketmq.consumer.group=my-group1
-rocketmq.consumer.topic=test
-rocketmq.topic=normal_topic_define_in_Aliware_MQ
+rocketmq.name-server=Endpoint_of_Cloud_MQ
Review Comment:
这种命名格式建议统一成小写， 下划线分隔
##########
rocketmq-spring-boot-samples/rocketmq-consume-acl-demo/src/main/resources/application.properties:
##########
@@ -16,13 +16,15 @@
spring.application.name=rocketmq-consume-acl-demo
-rocketmq.name-server=Endpoint_of_Aliware_MQ
-rocketmq.consumer.group=my-group1
-rocketmq.consumer.topic=test
-rocketmq.topic=normal_topic_define_in_Aliware_MQ
+rocketmq.name-server=Endpoint_of_Cloud_MQ
+# When set rocketmq.pull-consumer.group and rocketmq.pull-consumer.topic, rocketmqTemplate will start lite pull consumer
+# If you do not want to use lite pull consumer, please do not set rocketmq.pull-consumer.group and rocketmq.pull-consumer.topic
+rocketmq.pull-consumer.group=my-group1
+rocketmq.pull-consumer.topic=test
+rocketmq.topic=normal_topic_define_in_Cloud_MQ
# properties used in application code
-demo.rocketmq.transTopic=transaction_topic_define_in_Aliware_MQ
+demo.rocketmq.transTopic=transaction_topic_define_in_Cloud_MQ
Review Comment:
这种命名格式建议统一成小写， 下划线分隔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-spring] ShannonDing merged pull request #510: [ISSUE #511] Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #510:
URL: https://github.com/apache/rocketmq-spring/pull/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-spring] francisoliverlee commented on a diff in pull request #510: [ISSUE #511] Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on code in PR #510:
URL: https://github.com/apache/rocketmq-spring/pull/510#discussion_r1067721102
##########
rocketmq-spring-boot-samples/rocketmq-produce-acl-demo/src/main/resources/application.properties:
##########
@@ -13,10 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-rocketmq.name-server=Endpoint_of_Aliware_MQ
+rocketmq.name-server=Endpoint_of_CLOUD_MQ
rocketmq.producer.group=my-group1
rocketmq.producer.access-key=AK
rocketmq.producer.secret-key=SK
-demo.rocketmq.topic=normal_topic_define_in_Aliware_MQ
-demo.rocketmq.transTopic=transaction_topic_define_in_Aliware_MQ
+demo.rocketmq.topic=normal_topic_define_in_Cloud_MQ
Review Comment:
topic， group的名字格式建议都用小写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-spring] francisoliverlee commented on a diff in pull request #510: [ISSUE #511] Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on code in PR #510:
URL: https://github.com/apache/rocketmq-spring/pull/510#discussion_r1067721361
##########
rocketmq-spring-boot-samples/rocketmq-consume-acl-demo/src/main/java/org/apache/rocketmq/samples/springboot/ACLStringConsumer.java:
##########
@@ -26,8 +26,8 @@
*/
@Service
@RocketMQMessageListener(
- topic = "normal_topic_define_in_Aliware_MQ",
- consumerGroup = "group_define_in_Aliware_MQ"
+ topic = "normal_topic_define_in_Cloud_MQ",
+ consumerGroup = "group_define_in_Cloud_MQ"
Review Comment:
topic， group的名字格式建议都用小写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-spring] francisoliverlee commented on a diff in pull request #510: [ISSUE #511] Polish the application.properties to solve the misunderstanding between push consumer and pull consumer
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on code in PR #510:
URL: https://github.com/apache/rocketmq-spring/pull/510#discussion_r1067721565
##########
rocketmq-spring-boot-samples/rocketmq-consume-acl-demo/src/main/java/org/apache/rocketmq/samples/springboot/ACLStringTransactionalConsumer.java:
##########
@@ -27,7 +27,7 @@
@Service
@RocketMQMessageListener(
topic = "${demo.rocketmq.transTopic}",
- consumerGroup = "group_define_in_Aliware_MQ",
+ consumerGroup = "group_define_in_Cloud_MQ",
Review Comment:
topic， group的名字格式建议都用小写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org