You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/05/10 02:09:24 UTC

[jira] [Commented] (AVRO-1327) Having GenericEnumSymbol implement Comparable (mimic'ing java's Enum)

    [ https://issues.apache.org/jira/browse/AVRO-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653410#comment-13653410 ] 

Hudson commented on AVRO-1327:
------------------------------

Integrated in AvroJava #372 (See [https://builds.apache.org/job/AvroJava/372/])
    AVRO-1327. Java: Make GenericEnumSymbol implement Comparable. (Revision 1480769)

     Result = SUCCESS
cutting : 
Files : 
* /avro/trunk/CHANGES.txt
* /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java
* /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericEnumSymbol.java
* /avro/trunk/lang/java/avro/src/test/java/org/apache/avro/generic/TestGenericData.java

                
> Having GenericEnumSymbol implement Comparable (mimic'ing java's Enum)
> ---------------------------------------------------------------------
>
>                 Key: AVRO-1327
>                 URL: https://issues.apache.org/jira/browse/AVRO-1327
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.4
>            Reporter: Hernan Otero
>            Assignee: Doug Cutting
>             Fix For: 1.7.5
>
>         Attachments: AVRO-1327.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> It would be great if we could have GenericEnumSymbol implementing Comparable (either using int or String rep).
> This is mainly because GenericEnumSymbol is trying to mimic the java.lang.Enum and enums are inherently comparable that's why java.lang.Enum is Comparable. 
> Sorting Enum and GenericEnumSymbol is an action that we perform a lot. Making it Comparable frees us from explicit type checking and improves general code clarity and performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira