You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "gsmiller (via GitHub)" <gi...@apache.org> on 2023/05/25 16:25:18 UTC
[GitHub] [lucene] gsmiller opened a new pull request, #12331: GH#12321: Reduce visibility of StringsToAutomaton
gsmiller opened a new pull request, #12331:
URL: https://github.com/apache/lucene/pull/12331
### Description
As described in #12321, we can reduce our API surface area by making `StringsToAutomaton` pkg-private and asking users to go through `Automata` factory methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller merged pull request #12331: GH#12321: Reduce visibility of StringsToAutomaton
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller merged PR #12331:
URL: https://github.com/apache/lucene/pull/12331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12331: GH#12321: Reduce visibility of StringsToAutomaton
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12331:
URL: https://github.com/apache/lucene/pull/12331#issuecomment-1563235705
Please add info to the MIGRATE.txt like @mikemccand did in the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12331: GH#12321: Reduce visibility of StringsToAutomaton
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #12331:
URL: https://github.com/apache/lucene/pull/12331#issuecomment-1563313557
Created a separate PR for the "backport" of this work here: #12332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12331: GH#12321: Reduce visibility of StringsToAutomaton
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12331:
URL: https://github.com/apache/lucene/pull/12331#issuecomment-1563236854
We should add (in a separate PR) the static method to 9.x, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org