You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Savalek <gi...@git.apache.org> on 2018/08/06 15:13:26 UTC
[GitHub] zeppelin pull request #3113: [ZEPPELIN-3616] fix editor sections auto-collap...
GitHub user Savalek opened a pull request:
https://github.com/apache/zeppelin/pull/3113
[ZEPPELIN-3616] fix editor sections auto-collapse
# Description
This PR change logic of add new event listener on frontend. Now then add new event listener, also added destroy listener. Destroy listener attach to some DOM element and then this element destroyed listener drop event listener.
Since the old listeners were not deleted when changing the size of the paragraph / window, an error occurred. Because of this error, updating the text in the paragraph did not happen until the end.
## Info
#### PR type: `Bug Fix` | Jira issue: [`ZEPPELIN-3616`](https://issues.apache.org/jira/browse/ZEPPELIN-3616)
## Screenshots
### List of all resize event (after some time of work)
<p align="center">before (77 lis.)</p>
<p align="center">after (16 lis.)</p>
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3616
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3113
----
commit a07b59e081fbf1d21cb3795c7e01f67e7b38daa7
Author: Savalek <de...@...>
Date: 2018-08-06T13:29:22Z
[ZEPPELIN-3616] remove event if dom's element destroy
----
---
[GitHub] zeppelin issue #3113: [ZEPPELIN-3616] fix editor sections auto-collapse
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/3113
What about merge?
---
[GitHub] zeppelin pull request #3113: [ZEPPELIN-3616] fix editor sections auto-collap...
Posted by Savalek <gi...@git.apache.org>.
GitHub user Savalek reopened a pull request:
https://github.com/apache/zeppelin/pull/3113
[ZEPPELIN-3616] fix editor sections auto-collapse
# Description
This PR change logic of add new event listener on frontend. Now then add new event listener, also added destroy listener. Destroy listener attach to some DOM element and then this element destroyed listener drop event listener.
Since the old listeners were not deleted when changing the size of the paragraph / window, an error occurred. Because of this error, updating the text in the paragraph did not happen until the end.
## Info
#### PR type: `Bug Fix` | Jira issue: [`ZEPPELIN-3616`](https://issues.apache.org/jira/browse/ZEPPELIN-3616)
## Screenshots
### List of all resize event (after some time of work)
<p align="center">before (77 lis.)</p>
<p align="center">after (16 lis.)</p>
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3616
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3113
----
commit a07b59e081fbf1d21cb3795c7e01f67e7b38daa7
Author: Savalek <de...@...>
Date: 2018-08-06T13:29:22Z
[ZEPPELIN-3616] remove event if dom's element destroy
----
---
[GitHub] zeppelin pull request #3113: [ZEPPELIN-3616] fix editor sections auto-collap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3113
---
[GitHub] zeppelin pull request #3113: [ZEPPELIN-3616] fix editor sections auto-collap...
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek closed the pull request at:
https://github.com/apache/zeppelin/pull/3113
---
[GitHub] zeppelin issue #3113: [ZEPPELIN-3616] fix editor sections auto-collapse
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3113
ping @prabhjyotsingh @r-kamath
---
[GitHub] zeppelin issue #3113: [ZEPPELIN-3616] fix editor sections auto-collapse
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3113
Will merge this, if no more discussion.
---
[GitHub] zeppelin issue #3113: [ZEPPELIN-3616] fix editor sections auto-collapse
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3113
Apart from minor comment, rest LGTM
---
[GitHub] zeppelin pull request #3113: [ZEPPELIN-3616] fix editor sections auto-collap...
Posted by Savalek <gi...@git.apache.org>.
GitHub user Savalek reopened a pull request:
https://github.com/apache/zeppelin/pull/3113
[ZEPPELIN-3616] fix editor sections auto-collapse
# Description
This PR change logic of add new event listener on frontend. Now then add new event listener, also added destroy listener. Destroy listener attach to some DOM element and then this element destroyed listener drop event listener.
Since the old listeners were not deleted when changing the size of the paragraph / window, an error occurred. Because of this error, updating the text in the paragraph did not happen until the end.
## Info
#### PR type: `Bug Fix` | Jira issue: [`ZEPPELIN-3616`](https://issues.apache.org/jira/browse/ZEPPELIN-3616)
## Screenshots
### List of all resize event (after some time of work)
<p align="center">before (77 lis.)</p>
<p align="center">after (16 lis.)</p>
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3616
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3113
----
commit a07b59e081fbf1d21cb3795c7e01f67e7b38daa7
Author: Savalek <de...@...>
Date: 2018-08-06T13:29:22Z
[ZEPPELIN-3616] remove event if dom's element destroy
----
---
[GitHub] zeppelin pull request #3113: [ZEPPELIN-3616] fix editor sections auto-collap...
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek closed the pull request at:
https://github.com/apache/zeppelin/pull/3113
---
[GitHub] zeppelin issue #3113: [ZEPPELIN-3616] fix editor sections auto-collapse
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3113
cc @zjffdu @Leemoonsoo @prabhjyotsingh can you please merge this?
Thank you.
---