You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:19:09 UTC

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #539: generate parquet schema from rust struct

nevi-me commented on a change in pull request #539:
URL: https://github.com/apache/arrow-rs/pull/539#discussion_r668227649



##########
File path: parquet_derive/src/lib.rs
##########
@@ -69,7 +64,7 @@ mod parquet_field;
 ///     }
 ///   ];
 ///
-///  let schema = Arc::new(parse_message_type(schema_str).unwrap());
+///  let schema = samples.as_slice().schema();

Review comment:
       Yeah, I didn't like it too, but `RecordWriter` is implemented on &[Struct], so this was the least disruptive change to the trait I could make




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org