[jira] [Work logged] (GOBBLIN-1770) Fix Serialization of GaaSObservabilityEvent by allowing null values for Issue details and and properties

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1770?focusedWorklogId=841884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841884 ]

ASF GitHub Bot logged work on GOBBLIN-1770:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/23 00:11
            Start Date: 27/Jan/23 00:11
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #3630:
URL: https://github.com/apache/gobblin/pull/3630

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1770
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   When looking into the IssueRepository before the creation of GaaSObservabilityEvents, many issues do not populate their fields for details and summary. This is because the Issue details are composed of a stack trace, but since Issues can be composed of warn/error logs and stack traces, it is not guaranteed that every issue has a corresponding stack trace.
   
   However, from investigation it looks like the automated troubleshooter will always populate the issue severity, code, and summary.
   
   We should guard against this when generating a GaaSObservabilityEvent. 
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   The unit test will take the generate the event and attempt to serialize this against the schema. Previously, this would fail with a `NullPointerException`
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 841884)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix Serialization of GaaSObservabilityEvent by allowing null values for Issue details and and properties
> --------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1770
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1770
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When looking into the IssueRepository before the creation of GaaSObservabilityEvents, many issues do not populate their fields for details and summary. This is because the Issue details are composed of a stack trace, but since Issues can be composed of warn/error logs and stack traces, it is not guaranteed that every issue has a corresponding stack trace.
> However, from investigation it looks like the automated troubleshooter will always populate the issue severity, code, and summary.
> We should guard against this when generating a GaaSObservabilityEvent. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)