[GitHub] [arrow] westonpace commented on a diff in pull request #35222: MINOR: [C#] Serialize TotalBytes and TotalRecords in FlightInfo

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on code in PR #35222:
URL: https://github.com/apache/arrow/pull/35222#discussion_r1172000164


##########
csharp/test/Apache.Arrow.Flight.TestWeb/FlightHolder.cs:
##########
@@ -56,7 +56,7 @@ public FlightInfo GetFlightInfo()
                 new FlightEndpoint(new FlightTicket(_flightDescriptor.Paths.FirstOrDefault()), new List<FlightLocation>(){
                     new FlightLocation(_location)
                 })
-            });
+            }, 2, 4);

Review Comment:
   I don't really know how this test works but is this verified anywhere?  Otherwise it seems you might as well use the defaults. Also, should you do `totalRecords: 2, totalBytes: 4` for future readability (I don't really know what the convention is in the C# implementation so feel free to ignore)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org