You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jacktengg (via GitHub)" <gi...@apache.org> on 2025/04/18 02:50:55 UTC
[PR] [chore](type) assign explicit value for enum [doris]
jacktengg opened a new pull request, #50157:
URL: https://github.com/apache/doris/pull/50157
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #50157:
URL: https://github.com/apache/doris/pull/50157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814400408
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814633134
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/bf4ecb26fe69767d4bd6cf66339d0d7c87a27ae5_bf4ecb26fe69767d4bd6cf66339d0d7c87a27ae5/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/bf4ecb26fe69767d4bd6cf66339d0d7c87a27ae5_bf4ecb26fe69767d4bd6cf66339d0d7c87a27ae5/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.15% (14420/27132) |
| Line Coverage | 42.02% (124977/297455) |
| Region Coverage | 40.82% (63834/156379) |
| Branch Coverage | 35.46% (32104/90534) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814621485
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814537630
<details>
<summary>TPC-DS: <b>Total hot run time: 192714 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bf4ecb26fe69767d4bd6cf66339d0d7c87a27ae5, data reload: false
query1 1397 1069 1043 1043
query2 6304 1811 1790 1790
query3 11014 4534 4636 4534
query4 52280 24347 23610 23610
query5 5165 581 489 489
query6 335 209 211 209
query7 4870 496 269 269
query8 303 251 230 230
query9 5713 2532 2549 2532
query10 439 293 256 256
query11 15044 14983 14774 14774
query12 154 103 108 103
query13 1027 499 390 390
query14 9964 6253 6284 6253
query15 207 187 173 173
query16 7111 670 477 477
query17 1043 728 585 585
query18 1573 396 322 322
query19 192 174 161 161
query20 132 151 123 123
query21 206 122 108 108
query22 4323 4449 4306 4306
query23 34120 33433 33277 33277
query24 6580 2407 2411 2407
query25 477 498 445 445
query26 680 284 158 158
query27 2237 507 349 349
query28 3111 2158 2151 2151
query29 595 566 461 461
query30 281 224 198 198
query31 895 888 788 788
query32 68 62 63 62
query33 443 367 331 331
query34 764 879 530 530
query35 808 838 754 754
query36 943 991 915 915
query37 113 98 72 72
query38 4199 4324 4319 4319
query39 1523 1465 1461 1461
query40 210 118 110 110
query41 52 49 50 49
query42 117 103 103 103
query43 495 516 475 475
query44 1307 832 811 811
query45 182 171 166 166
query46 830 1028 635 635
query47 1898 1890 1809 1809
query48 382 413 304 304
query49 702 506 423 423
query50 652 707 405 405
query51 4250 4319 4213 4213
query52 112 101 101 101
query53 227 252 193 193
query54 570 572 516 516
query55 94 89 83 83
query56 298 289 305 289
query57 1192 1191 1122 1122
query58 261 256 273 256
query59 2717 2771 2585 2585
query60 355 320 337 320
query61 158 147 145 145
query62 736 752 675 675
query63 229 192 187 187
query64 1591 1019 708 708
query65 4436 4322 4294 4294
query66 763 395 304 304
query67 15849 15488 15286 15286
query68 7019 879 516 516
query69 549 309 261 261
query70 1177 1088 1110 1088
query71 492 316 277 277
query72 5997 4862 4975 4862
query73 1541 721 339 339
query74 8899 8947 8956 8947
query75 4123 3190 2737 2737
query76 4193 1194 754 754
query77 754 371 277 277
query78 10043 9941 9270 9270
query79 2305 811 557 557
query80 598 489 429 429
query81 482 248 217 217
query82 472 129 99 99
query83 300 259 232 232
query84 293 104 83 83
query85 799 353 306 306
query86 367 293 287 287
query87 4455 4377 4344 4344
query88 3774 2197 2149 2149
query89 404 312 286 286
query90 1813 203 210 203
query91 142 145 111 111
query92 77 56 56 56
query93 1945 935 575 575
query94 676 424 309 309
query95 368 287 287 287
query96 477 556 272 272
query97 3178 3242 3123 3123
query98 218 206 205 205
query99 1443 1395 1274 1274
Total cold run time: 296671 ms
Total hot run time: 192714 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814621450
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814399162
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814542644
<details>
<summary>ClickBench: <b>Total hot run time: 29.62 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bf4ecb26fe69767d4bd6cf66339d0d7c87a27ae5, data reload: false
query1 0.04 0.04 0.02
query2 0.13 0.11 0.11
query3 0.26 0.19 0.19
query4 1.59 0.20 0.19
query5 0.60 0.59 0.59
query6 1.19 0.70 0.72
query7 0.02 0.02 0.02
query8 0.04 0.04 0.03
query9 0.58 0.54 0.51
query10 0.57 0.57 0.58
query11 0.16 0.10 0.11
query12 0.14 0.11 0.11
query13 0.60 0.60 0.60
query14 1.16 1.17 1.19
query15 0.87 0.85 0.84
query16 0.39 0.38 0.39
query17 1.02 1.02 1.00
query18 0.21 0.20 0.20
query19 1.89 1.81 1.79
query20 0.01 0.01 0.01
query21 15.40 0.94 0.58
query22 0.75 1.12 0.63
query23 15.03 1.41 0.64
query24 6.74 2.59 0.85
query25 0.48 0.26 0.09
query26 0.62 0.16 0.14
query27 0.05 0.04 0.04
query28 9.77 0.84 0.46
query29 12.56 4.05 3.33
query30 0.27 0.09 0.05
query31 2.82 0.60 0.39
query32 3.22 0.54 0.48
query33 3.07 3.04 3.13
query34 15.71 5.25 4.47
query35 4.47 4.50 4.51
query36 0.69 0.49 0.49
query37 0.08 0.06 0.07
query38 0.05 0.04 0.03
query39 0.03 0.02 0.02
query40 0.16 0.13 0.13
query41 0.08 0.03 0.02
query42 0.04 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 103.59 s
Total hot run time: 29.62 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](type) assign explicit value for enum [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50157:
URL: https://github.com/apache/doris/pull/50157#issuecomment-2814523280
<details>
<summary>TPC-H: <b>Total hot run time: 33829 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bf4ecb26fe69767d4bd6cf66339d0d7c87a27ae5, data reload: false
------ Round 1 ----------------------------------
q1 26008 5053 5028 5028
q2 2071 271 179 179
q3 10411 1297 711 711
q4 10228 1009 529 529
q5 7518 2648 2315 2315
q6 179 161 136 136
q7 918 720 605 605
q8 9307 1261 1072 1072
q9 6644 5102 5093 5093
q10 6865 2314 1883 1883
q11 503 288 261 261
q12 340 345 220 220
q13 17774 3674 3080 3080
q14 237 228 216 216
q15 547 492 480 480
q16 449 446 401 401
q17 601 859 357 357
q18 7697 7264 7129 7129
q19 1574 944 533 533
q20 339 338 215 215
q21 4111 3321 2425 2425
q22 1051 1025 961 961
Total cold run time: 115372 ms
Total hot run time: 33829 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5143 5092 5097 5092
q2 241 330 229 229
q3 2138 2652 2245 2245
q4 1431 1813 1448 1448
q5 4456 4431 4420 4420
q6 216 169 129 129
q7 1963 1917 1774 1774
q8 2633 2550 2465 2465
q9 7218 7194 6869 6869
q10 3006 3212 2776 2776
q11 591 507 489 489
q12 705 784 586 586
q13 3483 3987 3290 3290
q14 290 294 290 290
q15 512 494 481 481
q16 461 520 489 489
q17 1162 1576 1357 1357
q18 7709 7593 7442 7442
q19 786 818 780 780
q20 1943 2037 1927 1927
q21 5199 4783 4780 4780
q22 1066 1050 976 976
Total cold run time: 52352 ms
Total hot run time: 50334 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org