You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/27 13:36:28 UTC
[GitHub] [apisix] membphis opened a new pull request #3698: ci: use the specified version of `skywalking`.
membphis opened a new pull request #3698:
URL: https://github.com/apache/apisix/pull/3698
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
fix #3696
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #3698: ci: use the specified version of `skywalking`.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #3698:
URL: https://github.com/apache/apisix/pull/3698#discussion_r584123788
##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -133,7 +133,7 @@ plugin_attr:
3. Run skywalking server:
```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server
+ sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.3.0-es7
Review comment:
I think there should be `8.3.0-es7`.
I got it from https://github.com/apache/skywalking-docker/blob/master/oap-server/README.md
Or we can remove the doc about `Of Course, you can use Elasticsearch storage`, just link to the doc of SkyWalking.
what do you think @moonming ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #3698: ci: use the specified version of `skywalking`.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #3698:
URL: https://github.com/apache/apisix/pull/3698#discussion_r584123984
##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -133,7 +133,7 @@ plugin_attr:
3. Run skywalking server:
```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server
+ sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.3.0-es7
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #3698: ci: use the specified version of `skywalking`.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #3698:
URL: https://github.com/apache/apisix/pull/3698#discussion_r584123835
##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -133,7 +133,7 @@ plugin_attr:
3. Run skywalking server:
```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server
+ sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.3.0-es7
Review comment:
yes, you are right. update it later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3698: ci: use the specified version of `skywalking`.
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3698:
URL: https://github.com/apache/apisix/pull/3698#discussion_r584123270
##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -133,7 +133,7 @@ plugin_attr:
3. Run skywalking server:
```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server
+ sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.3.0-es7
Review comment:
Should be `8.3.0-es6`?
##########
File path: docs/zh/latest/plugins/skywalking.md
##########
@@ -136,7 +136,7 @@ plugin_attr:
3. 启动 skywalking：
```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server
+ sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.3.0-es7
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3698: ci: use the specified version of `skywalking`.
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3698:
URL: https://github.com/apache/apisix/pull/3698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org