You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/08/30 21:50:15 UTC
Review Request 68580: ATLAS-2851: Retrieving entity with SET attribute
contains duplicate entries if attribute type updated from LIST to SET
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68580/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2851
https://issues.apache.org/jira/browse/ATLAS-2851
Repository: atlas
Description
-------
Retrieving entity with SET attribute type contains duplicate entries if attribute type updated from LIST to SET
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 5a863b733
Diff: https://reviews.apache.org/r/68580/diff/1/
Testing
-------
Validated that SET attributes returns unique values even if graph store contains duplicate value for the attribute.
Thanks,
Sarath Subramanian
Re: Review Request 68580: ATLAS-2851: Retrieving entity with SET
attribute
contains duplicate entries if attribute type updated from LIST to SET
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68580/#review208208
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 31, 2018, 11:06 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68580/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 11:06 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2851
> https://issues.apache.org/jira/browse/ATLAS-2851
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Retrieving entity with SET attribute type contains duplicate entries if attribute type updated from LIST to SET
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java b4189d2d1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java c57e30ab5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 0d9cb05ca
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 5a863b733
>
>
> Diff: https://reviews.apache.org/r/68580/diff/2/
>
>
> Testing
> -------
>
> Validated that SET attributes returns unique values even if graph store contains duplicate value for the attribute.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 68580: ATLAS-2851: Retrieving entity with SET
attribute
contains duplicate entries if attribute type updated from LIST to SET
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68580/
-----------------------------------------------------------
(Updated Aug. 31, 2018, 4:06 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2851
https://issues.apache.org/jira/browse/ATLAS-2851
Repository: atlas
Description
-------
Retrieving entity with SET attribute type contains duplicate entries if attribute type updated from LIST to SET
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java b4189d2d1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java c57e30ab5
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 0d9cb05ca
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 5a863b733
Diff: https://reviews.apache.org/r/68580/diff/2/
Changes: https://reviews.apache.org/r/68580/diff/1-2/
Testing
-------
Validated that SET attributes returns unique values even if graph store contains duplicate value for the attribute.
Thanks,
Sarath Subramanian
Re: Review Request 68580: ATLAS-2851: Retrieving entity with SET
attribute
contains duplicate entries if attribute type updated from LIST to SET
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68580/#review208151
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 30, 2018, 9:50 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68580/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 9:50 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2851
> https://issues.apache.org/jira/browse/ATLAS-2851
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Retrieving entity with SET attribute type contains duplicate entries if attribute type updated from LIST to SET
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 5a863b733
>
>
> Diff: https://reviews.apache.org/r/68580/diff/1/
>
>
> Testing
> -------
>
> Validated that SET attributes returns unique values even if graph store contains duplicate value for the attribute.
>
>
> Thanks,
>
> Sarath Subramanian
>
>