You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/12 15:25:22 UTC
[GitHub] flink pull request #4312: [FLINK-6550] Reject null OutputTags in Context#col...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4312
[FLINK-6550] Reject null OutputTags in Context#collect(OutputTag<X>, X)
@aljoscha what do you think?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6550
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4312
----
commit 380d250b1cdd9a3fc461679db9eb1683ea5bdf73
Author: zentol <ch...@apache.org>
Date: 2017-06-19T13:57:14Z
[FLINK-6550] Reject null OutputTags in Context#collect(OutputTag<X>, X)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4312: [FLINK-6550] Reject null OutputTags in Context#collect(Ou...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4312
LGTM! 👍
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4312: [FLINK-6550] Reject null OutputTags in Context#collect(Ou...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4312
I think this is a good case where the new pull request template would have been useful.
This is in fact a change with potential performance impact.
Part of the result of the last micro-benchmarks by Piotr was that we already introduced overhead and performance regressions along the collectors and contexts. Additional branch and method indirection did
eventually add up to make the code less efficient and less JIT friendly.
I am very worried that these types of changes continue to be made without any consideration of potential impact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4312: [FLINK-6550] Reject null OutputTags in Context#col...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4312: [FLINK-6550] Reject null OutputTags in Context#collect(Ou...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4312
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---