[jira] [Commented] (SPARK-25745) docker-image-tool.sh ignores errors from Docker

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651630#comment-16651630 ] 

Apache Spark commented on SPARK-25745:
--------------------------------------

User 'rvesse' has created a pull request for this issue:
https://github.com/apache/spark/pull/22748

> docker-image-tool.sh ignores errors from Docker
> -----------------------------------------------
>
>                 Key: SPARK-25745
>                 URL: https://issues.apache.org/jira/browse/SPARK-25745
>             Project: Spark
>          Issue Type: Bug
>          Components: Deploy, Kubernetes
>    Affects Versions: 2.3.0, 2.3.1, 2.3.2
>            Reporter: Rob Vesse
>            Priority: Major
>
> In attempting to use the {{docker-image-tool.sh}} scripts to build some custom Dockerfiles I ran into issues with the scripts interaction with Docker.  Most notably if the Docker build/push fails the script continues blindly ignoring the errors.  This can either result in complete failure to build or lead to subtle bugs where images are built against different base images than expected.
> Additionally while the Dockerfiles assume that Spark is first built locally the scripts fail to validate this which they could easily do by checking the expected JARs location.  This can also lead to failed Docker builds which could easily be avoided.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org