You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/05/15 09:20:12 UTC

[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #82: Modify the maven jdk compilation version

gosonzhang commented on a change in pull request #82:
URL: https://github.com/apache/incubator-tubemq/pull/82#discussion_r425675125



##########
File path: pom.xml
##########
@@ -100,8 +100,8 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>3.1</version>
                 <configuration>
-                    <source>1.8</source>
-                    <target>1.8</target>
+                    <source>1.7</source>

Review comment:
       I think it would be perfect if you add a comment here to tell the following partners why this setting is necessary: the JAVA version of the environment where the client is located may be different from the server, tubemq-client, tubemq-core should maintain the 1.7 version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org