You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2019/11/03 08:26:28 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #794: Feature prometheus

membphis commented on a change in pull request #794: Feature prometheus
URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341840534
 
 

 ##########
 File path: lua/apisix/plugins/prometheus/exporter.lua
 ##########
 @@ -44,26 +47,35 @@ function _M.init()
     -- per service
     metrics.status = prometheus:counter("http_status",
             "HTTP status codes per service in Apisix",
-            {"code", "service"})
+            {"code", "service", "node"})
+
+    metrics.latency = prometheus:histogram("http_latency",
+        "HTTP request latency per service in Apisix",
 
 Review comment:
   "HTTP request latency per service in Apisix" -> "HTTP request latency per service in APISIX"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services