You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey A. Ivanov (JIRA)" <ji...@apache.org> on 2006/10/11 14:16:21 UTC
[jira] Created: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
[classlib][swing] Some excluded tests pass
------------------------------------------
Key: HARMONY-1825
URL: http://issues.apache.org/jira/browse/HARMONY-1825
Project: Harmony
Issue Type: Bug
Components: build - test - ci
Reporter: Alexey A. Ivanov
Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446532 ]
Alexey A. Ivanov commented on HARMONY-1825:
-------------------------------------------
That's bad.
Thank you for your support, Mark!
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=all ]
Alexey A. Ivanov updated HARMONY-1825:
--------------------------------------
Attachment: H1825-PlainViewTest.debug-not-to-commit.patch
Thank you, Mark.
Could you please apply "H1825-PlainViewTest.debug-not-to-commit.patch" to your workspace and run PlainViewTest again, and then report the test output?
Thank you in advance,
Alexey.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=all ]
Mark Hindess reassigned HARMONY-1825:
-------------------------------------
Assignee: Mark Hindess
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446199 ]
Mark Hindess commented on HARMONY-1825:
---------------------------------------
I get:
[junit] [0]: '1: 0
[junit] ' = 18
[junit] [1]: '2: 012345
[junit] ' = 57
[junit] [2]: '3:
[junit] ' = 11
[junit] [3]: '
[junit] ' = 0
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12443754 ]
Alexey A. Ivanov commented on HARMONY-1825:
-------------------------------------------
Mark, thanks for trying these patches.
I'll take a close look at PlainViewTest as well.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446174 ]
Mark Hindess commented on HARMONY-1825:
---------------------------------------
The full failure message looks like:
junit.framework.AssertionFailedError: expected:<57.0>
but was:<86.0> at
javax.swing.text.PlainViewTest.testGetPreferredSpan
(PlainViewTest.java:111) at
java.lang.reflect.AccessibleObject.invokeV
(AccessibleObject.java:25) at
javax.swing.BasicSwingTestCase.runBareSuper
(BasicSwingTestCase.java:117) at
javax.swing.SwingTestCase$1.run
(SwingTestCase.java:45) at
java.awt.event.InvocationEvent.runAndNotify
(InvocationEvent.java:88) at
java.awt.event.InvocationEvent.dispatch
(InvocationEvent.java:77) at
java.awt.EventQueueCore.dispatchEventImpl
(EventQueueCore.java:131) at
java.awt.EventQueue.dispatchEvent
(EventQueue.java:144) at
java.awt.EventDispatchThread.runModalLoop
(EventDispatchThread.java:75) at
java.awt.EventDispatchThread.run
(EventDispatchThread.java:48)
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446282 ]
Mark Hindess commented on HARMONY-1825:
---------------------------------------
It fails in the same way so see the stack trace above (modulo the line numbers changed by your patch).
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446252 ]
Mark Hindess commented on HARMONY-1825:
---------------------------------------
I'm afraid it fails the same way and outputs:
[junit] Running javax.swing.text.PlainViewTest
[junit] javax.swing.plaf.FontUIResource[family=Default,name=Dialog,style=plain,size=12]
[junit] javax.swing.plaf.FontUIResource[family=Default,name=Dialog,style=plain,size=12]
[junit] Tests run: 8, Failures: 1, Errors: 0, Time elapsed: 1.374 sec
[junit] Test javax.swing.text.PlainViewTest FAILED
This is a little tedious but I'm happy to persist in tracking down this problem. Thank you for looking at it.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446545 ]
Mark Hindess commented on HARMONY-1825:
---------------------------------------
I wonder if this is related to the fact that Debian comes with freetype2? I know I made a couple of changes to get this to compile but they were quite simple (just a change of interface not implementation I think) and I tested the native code I changed produced the same results as an older freetype version that compiled okay.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=all ]
Alexey A. Ivanov updated HARMONY-1825:
--------------------------------------
Attachment: H1825-PlainViewTest.debug-not-to-commit.patch
Thank you once again. This is how it should be.
Then it seems like the field view.metrics is modified as the result of view.getPreferredSpan() call. To confirm this is the case, could you please apply the new patch (onto the unmodified file). If this is the case, the test would fail with "Font metrics changed" message. Fonts of the two metrics are dumped to System.err.
Thank you in advance, Mark.
P.S. I'm just trying to figure out what's happening there. And thank you very much for you help 'cause I can't find any machine where this test fails.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12443750 ]
Mark Hindess commented on HARMONY-1825:
---------------------------------------
Alexey, thanks for taking a look at these.
in addition to the two tests mentioned in comments in HARMONY-1910 I also see the following failure:
javax.swing.text.PlainViewTest:
testGetPreferredSpan expected:<57.0> but was:<86.0>
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446254 ]
Alexey A. Ivanov commented on HARMONY-1825:
-------------------------------------------
Fonts seem to be the same.
But what assertion has failed? What is stack trace for the failure?
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=all ]
Alexey A. Ivanov updated HARMONY-1825:
--------------------------------------
Attachment: H1825-test-unexclude.patch
The updated patch. After applying HARMONY-1856, there appeared some rejects. To avoid them, I'm uploading the updated patch.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Attachments: H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=all ]
Alexey A. Ivanov updated HARMONY-1825:
--------------------------------------
Attachment: H1825-test-unexclude.patch
Modifies build.xml to remove tests from the exclude list.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Attachments: H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12445638 ]
Alexey A. Ivanov commented on HARMONY-1825:
-------------------------------------------
Mark, can you tell me the line number where PlainViewTest.testGetPreferredSpan() failed?
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12447723 ]
Alexey A. Ivanov commented on HARMONY-1825:
-------------------------------------------
Mark,
Does it make sense to remove the tests which pass successfully right now?
And then track PlainViewTest failure in a separate issue?
I believe it's better to extend testing base 'cause it may help to catch another bug or problem with following fixes. What do you think?
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded
tests pass
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446591 ]
Alexey A. Ivanov commented on HARMONY-1825:
-------------------------------------------
It shouldn't fail any way because text is measured in the test the same way it is measured by PlainView. (It's a little more tricky in PlainView though but equivalent.)
My guess was that font metrics get changed (getPreferredSpan updates them if necessary), but I was wrong here as well. However they shouldn't change since font of JTextArea couldn't change on its own.
I ran along all the code of getPreferredSpan (incl. methods it calls), and I see no reason why it could return other result rather than the expected one.
But there's a reason -- no miracles; and it can lurk in lower layers than Swing is.
> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
> Key: HARMONY-1825
> URL: http://issues.apache.org/jira/browse/HARMONY-1825
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch, H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without any modification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira