[jira] [Commented] (MNG-6233) maven-resolver-provider mixes JRS 330 and Plexus annotations

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023784#comment-16023784 ] 

Michael Osipov commented on MNG-6233:
-------------------------------------

bq. I am not sure what you mean by "merged Jason Dillon's changed with this PR". The change I propose fully converts maven-resolver-provider to jsr330 annotations, which means only jsr330 codepaths are used after the change and our existing ITs prove everything works. In other words, it is not possible to implement jsr330 conversion (i.e. this change) without fixing Jason's problem too, so this change really supersedes PR 116.

OK, that's what I wanted to know.
Though, the commit message does not has the same title as the JIRA issue and you should have simply added "This closes #116" too.

The change itself is perfectly fine.

> maven-resolver-provider mixes JRS 330 and Plexus annotations
> ------------------------------------------------------------
>
>                 Key: MNG-6233
>                 URL: https://issues.apache.org/jira/browse/MNG-6233
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.3.9, 3.5.0
>            Reporter: Igor Fedorenko
>            Assignee: Igor Fedorenko
>             Fix For: 3.5.1
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and impossible to workaround problems in applications that embed Maven core runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan is to update the code to use jsr330 exclusively and completely remove plexus annotations. This change is fully transparent to the users (and we've been using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)