You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "D.J. Heap" <dj...@shadyvale.net> on 2004/03/13 01:05:15 UTC
[PATCH] run-repos-tests.py fix for Windows
Log:
Use the safe_rmtree method (from the cmdline test suite) of removing old
repositories since they now have read-only files which Windows will not
delete.
* subversion/tests/python-libs/exectest.py
(safe_rmtree, chmod_tree): New methods copied from
subversion/tests/clients/cmdline/svntest/main.py for safely
removing file trees.
(run_tests): Use the new safe_rmtree.
Re: [PATCH] run-repos-tests.py fix for Windows
Posted by "D.J. Heap" <dj...@shadyvale.net>.
Philip Martin wrote:
> "D.J. Heap" <dj...@shadyvale.net> writes:
>
>
>>Log:
>>Use the safe_rmtree method (from the cmdline test suite) of removing
>>old repositories since they now have read-only files which Windows
>>will not delete.
>
>
> My "making it read-only in the repository appears harmless" comment
> proved less than accurate :-(
[snip]
Heh, it only affected the repository cleanup piece of the test. I
really wish NTFS behaved more like unixy filesystems...they just make so
much more sense.
Thanks! Committed in r9027.
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] run-repos-tests.py fix for Windows
Posted by Philip Martin <ph...@codematters.co.uk>.
"D.J. Heap" <dj...@shadyvale.net> writes:
> Log:
> Use the safe_rmtree method (from the cmdline test suite) of removing
> old repositories since they now have read-only files which Windows
> will not delete.
My "making it read-only in the repository appears harmless" comment
proved less than accurate :-(
> * subversion/tests/python-libs/exectest.py
> (safe_rmtree, chmod_tree): New methods copied from
> subversion/tests/clients/cmdline/svntest/main.py for safely
> removing file trees.
> (run_tests): Use the new safe_rmtree.
It's OK on Linux but I don't have Windows. I assume that you have
tested it on Windows, so it's OK for the trunk.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org