***UNCHECKED*** [jira] [Commented] (FLINK-9885) End-to-end test: Elasticsearch 6.x connector

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555246#comment-16555246 ] 

ASF GitHub Bot commented on FLINK-9885:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6391#discussion_r204990734
  
    --- Diff: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java ---
    @@ -0,0 +1,91 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.elasticsearch6;
    +
    +import org.apache.flink.streaming.connectors.elasticsearch.ActionRequestFailureHandler;
    +import org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkBase;
    +import org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkFunction;
    +import org.apache.flink.streaming.connectors.elasticsearch.util.NoOpFailureHandler;
    +
    +import org.apache.http.HttpHost;
    +import org.elasticsearch.action.ActionRequest;
    +import org.elasticsearch.action.DocWriteRequest;
    +import org.elasticsearch.action.bulk.BulkProcessor;
    +import org.elasticsearch.client.RestHighLevelClient;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * Elasticsearch 6.x sink that requests multiple {@link ActionRequest ActionRequests}
    + * against a cluster for each incoming element.
    + *
    + * <p>The sink internally uses a {@link RestHighLevelClient} to communicate with an Elasticsearch cluster.
    + * The sink will fail if no cluster can be connected to using the provided transport addresses passed to the constructor.
    + *
    + * <p>The {@link Map} passed to the constructor is used to create the {@code TransportClient}. The config keys can be found
    + * in the <a href="https://www.elastic.io">Elasticsearch documentation</a>. An important setting is {@code cluster.name},
    + * which should be set to the name of the cluster that the sink should emit to.
    + *
    + * <p>Internally, the sink will use a {@link BulkProcessor} to send {@link ActionRequest ActionRequests}.
    + * This will buffer elements before sending a request to the cluster. The behaviour of the
    + * {@code BulkProcessor} can be configured using these config keys:
    + * <ul>
    + *   <li> {@code bulk.flush.max.actions}: Maximum amount of elements to buffer
    + *   <li> {@code bulk.flush.max.size.mb}: Maximum amount of data (in megabytes) to buffer
    + *   <li> {@code bulk.flush.interval.ms}: Interval at which to flush data regardless of the other two
    + *   settings in milliseconds
    + * </ul>
    + *
    + * <p>You also have to provide an {@link ElasticsearchSinkFunction}. This is used to create multiple
    + * {@link ActionRequest ActionRequests} for each incoming element. See the class level documentation of
    + * {@link ElasticsearchSinkFunction} for an example.
    + *
    + * @param <T> Type of the elements handled by this sink
    + */
    +public class ElasticsearchSink<T> extends ElasticsearchSinkBase<T> {
    --- End diff --
    
    Add `@PublicEvolving`


> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
>                 Key: FLINK-9885
>                 URL: https://issues.apache.org/jira/browse/FLINK-9885
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ElasticSearch Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This should also come with an end-to-end test that covers this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)