[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8478: Change Service Info revision cal structure

[GitBox <gi...@apache.org>]

AlbumenJ commented on a change in pull request #8478:
URL: https://github.com/apache/dubbo/pull/8478#discussion_r687321976



##########
File path: dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java
##########
@@ -409,17 +405,7 @@ public boolean hasMethodParameter(String method) {
         }
 
         public String toDescString() {
-            return this.getMatchKey() + getMethodSignaturesString() + new TreeMap<>(getParams());
-        }
-
-        private String getMethodSignaturesString() {
-            SortedSet<String> methodStrings = new TreeSet();
-
-            Method[] methods = ClassUtils.forName(name).getMethods();
-            for (Method method : methods) {
-                methodStrings.add(method.toString());
-            }
-            return methodStrings.toString();
+            return this.getMatchKey() + name + group + version + path + protocol + new TreeMap<>(getParams());

Review comment:
       done, `getMatchKey()` contains `name + group + version + protocol`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org