You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2013/11/07 16:14:33 UTC
Review Request 15308: HIVE-5564: Need to accomodate table decimal columns
that were defined prior to HIVE-3976
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15308/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-5564
https://issues.apache.org/jira/browse/HIVE-5564
Repository: hive-git
Description
-------
Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c
ql/src/test/queries/clientpositive/decimal_1.q f8b3661
ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15308/diff/
Testing
-------
Manually tested.
Thanks,
Xuefu Zhang
Re: Review Request 15308: HIVE-5564: Need to accomodate table decimal
columns that were defined prior to HIVE-3976
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15308/#review28375
-----------------------------------------------------------
LGTM to me. Just two minor issues below.
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
<https://reviews.apache.org/r/15308/#comment55192>
Can you remove these tabs?
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
<https://reviews.apache.org/r/15308/#comment55193>
Thank you very much for fixing this error message! One nit, I think we should stick with an IllegalArgException as opposed to runtime since it looks more appropriate.
- Brock Noland
On Nov. 7, 2013, 3:14 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15308/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 3:14 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5564
> https://issues.apache.org/jira/browse/HIVE-5564
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c
> ql/src/test/queries/clientpositive/decimal_1.q f8b3661
> ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15308/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15308: HIVE-5564: Need to accomodate table decimal
columns that were defined prior to HIVE-3976
Posted by Xuefu Zhang <xz...@cloudera.com>.
> On Nov. 7, 2013, 7:20 p.m., Jason Dere wrote:
> > ql/src/test/queries/clientpositive/decimal_1.q, line 5
> > <https://reviews.apache.org/r/15308/diff/1/?file=380431#file380431line5>
> >
> > I don't think this is actually able to test the scenario that you intend - this is going to test the fact that a newly created table with column type "decimal" will get translated to decimal(10,0), but this is because of the parser changes in your original decimal patch. So I don't think a qfile test is the right thing here - how about doing a JUnit to directly test the TypeInfoParser behavior? Using the example above you can test the typestring "decimal(4,2):decimal(5):decimal" and see if you get the correct TypeInfos back.
This is not mean to test the upgrade part. I manually tested that. Feel free to do so if you'd like.
- Xuefu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15308/#review28420
-----------------------------------------------------------
On Nov. 7, 2013, 3:14 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15308/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 3:14 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5564
> https://issues.apache.org/jira/browse/HIVE-5564
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c
> ql/src/test/queries/clientpositive/decimal_1.q f8b3661
> ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15308/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15308: HIVE-5564: Need to accomodate table decimal
columns that were defined prior to HIVE-3976
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15308/#review28420
-----------------------------------------------------------
ql/src/test/queries/clientpositive/decimal_1.q
<https://reviews.apache.org/r/15308/#comment55234>
I don't think this is actually able to test the scenario that you intend - this is going to test the fact that a newly created table with column type "decimal" will get translated to decimal(10,0), but this is because of the parser changes in your original decimal patch. So I don't think a qfile test is the right thing here - how about doing a JUnit to directly test the TypeInfoParser behavior? Using the example above you can test the typestring "decimal(4,2):decimal(5):decimal" and see if you get the correct TypeInfos back.
- Jason Dere
On Nov. 7, 2013, 3:14 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15308/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 3:14 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5564
> https://issues.apache.org/jira/browse/HIVE-5564
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c
> ql/src/test/queries/clientpositive/decimal_1.q f8b3661
> ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15308/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15308: HIVE-5564: Need to accomodate table decimal
columns that were defined prior to HIVE-3976
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15308/#review28980
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Nov. 13, 2013, 3:41 a.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15308/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 3:41 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5564
> https://issues.apache.org/jira/browse/HIVE-5564
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c
> ql/src/test/queries/clientpositive/decimal_1.q f8b3661
> ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15308/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15308: HIVE-5564: Need to accomodate table decimal
columns that were defined prior to HIVE-3976
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15308/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:41 a.m.)
Review request for hive.
Bugs: HIVE-5564
https://issues.apache.org/jira/browse/HIVE-5564
Repository: hive-git
Description
-------
Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c
ql/src/test/queries/clientpositive/decimal_1.q f8b3661
ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15308/diff/
Testing
-------
Manually tested.
Thanks,
Xuefu Zhang
Re: Review Request 15308: HIVE-5564: Need to accomodate table decimal
columns that were defined prior to HIVE-3976
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15308/
-----------------------------------------------------------
(Updated Nov. 7, 2013, 8:23 p.m.)
Review request for hive.
Bugs: HIVE-5564
https://issues.apache.org/jira/browse/HIVE-5564
Repository: hive-git
Description
-------
Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c
ql/src/test/queries/clientpositive/decimal_1.q f8b3661
ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15308/diff/
Testing
-------
Manually tested.
Thanks,
Xuefu Zhang