You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by jo...@gmail.com on 2010/02/19 20:18:06 UTC

Re: Serve cached stale data if receiveing external server error for a resource (issue214045)

Nothing new here. We need a DefaultRequestPipelineTest though.


http://codereview.appspot.com/214045/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
(right):

http://codereview.appspot.com/214045/diff/1/4#newcode240
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java:240:
return true;
+1

http://codereview.appspot.com/214045/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
(right):

http://codereview.appspot.com/214045/diff/1/2#newcode57
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java:57:
HttpResponse staledResponse = null;
nit: s/staled/stale/

http://codereview.appspot.com/214045/show