You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/23 08:34:29 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5708: vmware: fix cpu reservation during vm scale
shwstppr opened a new pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708
### Description
Fixes #5706
Correctly set CPU reservation while scaling a dynamically scalable VM.
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-986570619
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977572136
@DaanHoogland updated summary for screenshots.
Before fix, ACS sets CPU reservation for the VM while scaling irrespective of the value of global setting - vmware.reserve.cpu. It should be set only when vmware.reserve.cpu is true. Also, it maybe wrong as it is not calculated the same way as it is done during VM deployment.
After fix, the same method is used for setting CPU reservation which is used during VM deployment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-985508160
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977591816
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-986569912
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-976288995
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-976288390
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-986500284
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#discussion_r755022167
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -1765,7 +1765,7 @@ protected ScaleVmAnswer execute(ScaleVmCommand cmd) {
// Check if license supports the feature
VmwareHelper.isFeatureLicensed(hyperHost, FeatureKeyConstants.HOTPLUG);
- VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), vmSpec.getMinSpeed(), (int) requestedMaxMemoryInMb, ramMb,
+ VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), getReservedCpuMHZ(vmSpec), (int) requestedMaxMemoryInMb, ramMb,
Review comment:
How about min of both min speed and reserved mhz?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977594224
<b>Trillian Build Failed (tid-2579)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-985478863
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977866606
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977864894
@sureshanaparti I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos7', 'centos6', 'alma8', 'ubuntu18', 'suse15', 'ubuntu20', 'rocky8', 'centos8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache', 'NuxRo']
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-987059532
<b>Trillian test result (tid-2623)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34009 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5708-t2623-vmware-67u3.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-985479277
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-976356526
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#discussion_r755747038
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -1765,7 +1765,7 @@ protected ScaleVmAnswer execute(ScaleVmCommand cmd) {
// Check if license supports the feature
VmwareHelper.isFeatureLicensed(hyperHost, FeatureKeyConstants.HOTPLUG);
- VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), vmSpec.getMinSpeed(), (int) requestedMaxMemoryInMb, ramMb,
+ VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), getReservedCpuMHZ(vmSpec), (int) requestedMaxMemoryInMb, ramMb,
Review comment:
yes getReservedCpuMHZ() makes sense, since it will set 0 if VmwareReserveCPU is false which is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977865822
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977864095
@blueorangutan help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-977591642
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-978471944
<b>Trillian test result (tid-2581)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36439 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5708-t2581-vmware-67u3.zip
Smoke tests completed. 89 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_createPortablePublicIPAcquire | `Error` | 0.04 | test_portable_publicip.py
test_createPortablePublicIPRange | `Error` | 0.02 | test_portable_publicip.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 429.62 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-986499849
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#discussion_r755028304
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -1765,7 +1765,7 @@ protected ScaleVmAnswer execute(ScaleVmCommand cmd) {
// Check if license supports the feature
VmwareHelper.isFeatureLicensed(hyperHost, FeatureKeyConstants.HOTPLUG);
- VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), vmSpec.getMinSpeed(), (int) requestedMaxMemoryInMb, ramMb,
+ VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), getReservedCpuMHZ(vmSpec), (int) requestedMaxMemoryInMb, ramMb,
Review comment:
@rhtyd `getReservedCpuMHZ()` method seems to be using min CPU speed itself based CPU reservation global setting.
https://github.com/apache/cloudstack/blob/4.16/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L3052-L3057
Same method is used while deploying VM, https://github.com/apache/cloudstack/blob/4.16/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L1999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-986548813
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-985505296
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5708: vmware: fix cpu reservation during vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#issuecomment-988216607
<b>Trillian Build Failed (tid-2635)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org