You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/04/26 08:31:46 UTC

DO NOT REPLY [Bug 53151] New: Tomcat 7 SimpleTCPCluster.java does not send payload on Start & Stop

https://issues.apache.org/bugzilla/show_bug.cgi?id=53151

             Bug #: 53151
           Summary: Tomcat 7 SimpleTCPCluster.java does not send payload
                    on Start & Stop
           Product: Tomcat 7
           Version: 7.0.27
          Platform: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Cluster
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: saplenm@yahoo.com
    Classification: Unclassified


In Tomcat 6, it used to send Cluster Payload as part of start() and stop()
method.

In Tomcat 7, the functionality is missing fro startInternal() and
stopInternal() methods.

Tomcat 7 Current Implementation for SimpleTcpCluster.java
========================================================================
@Override
    protected void startInternal() throws LifecycleException {

        if (log.isInfoEnabled()) log.info("Cluster is about to start");

        fireLifecycleEvent(BEFORE_START_EVENT, this); --> This line missing
which was present in Tomcat 6
        try {
            checkDefaults();
            registerClusterValve();
            channel.addMembershipListener(this);
            channel.addChannelListener(this);
            channel.start(channelStartOptions);
            if (clusterDeployer != null) clusterDeployer.start();
            //register JMX objects
            ClusterJmxHelper.registerDefaultCluster(this);
            // Notify our interested LifecycleListeners
        } catch (Exception x) {
            log.error("Unable to start cluster.", x);
            throw new LifecycleException(x);
        }
        fireLifecycleEvent(AFTER_START_EVENT, this);--> This line missing which
was present in Tomcat 6

        setState(LifecycleState.STARTING);
    }


========================================================================

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 53151] Tomcat 7 SimpleTCPCluster.java does not send payload on Start & Stop

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53151

Nilesh <sa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|                            |All

--- Comment #1 from Nilesh <sa...@yahoo.com> 2012-04-26 06:34:51 UTC ---
Similar issue present for stopInternal() Method.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 53151] Tomcat 7 SimpleTCPCluster.java does not send payload on Start & Stop

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53151

Keiichi Fujino <kf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #2 from Keiichi Fujino <kf...@apache.org> 2012-04-27 04:20:25 UTC ---
Life-cycle implementation was refactored in Tomcat7 .
As the result, SimpleTcpCluster in Tomcat7 has inherited LifecycleBase and
LifecycleBase notifies a life cycle event. 
Therefore, the upper code is unnecessary to the SimpleTcpCluster in Tomcat7. 

However, as the side effects of this refactoring, 
In Tomcat7.0, instance of SimpleTcpCluster is no longer set to the data field
of LifecycleEvent. 
In Tomcat6, it was set as the second argument. 
Therefore, if your LifecycleListener used getData() method in order to get
instance of SimpleTcpCluster, 
you must use getLifecycle() method instead of getData() method.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 53151] Tomcat 7 SimpleTCPCluster.java does not send payload on Start & Stop

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53151

--- Comment #3 from Nilesh <sa...@yahoo.com> 2012-04-27 06:01:48 UTC ---
Thanks Keiichi for the detailed reply. Appreciated!

Thanks

Nilesh

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org