You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/07 00:16:06 UTC
[GitHub] [skywalking-swck] hanahmily opened a new pull request #5: Update README.md
hanahmily opened a new pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5
Basic guides how to deploy swck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723541870
Let's release our operator😀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519157508
##########
File path: README.md
##########
@@ -1,3 +1,77 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+ 1. Create the `skywalking-swck-system` namespace:
+ ```
+ kubectl create namespace skywalking-swck-system
+ ```
+ 1. Apply the manifests for the Controller and CRDs in release/config:
+ ```
+ kubectl apply -f release/config
+ ```
+
+# Guides of Deployment
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone git@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/default/kustomization.yaml` file to change your preferences. If you prefer to your private docker image, a quick path to override `IMG` environment variable : `export IMG=<private registry>/controller:<tag>`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make deploy
+```
+
+4. Deploy the CRDs:
+
+```sh
+make install
+```
+
+## Test your deployment
+
+1. Deploy a sample OAP server, this will create a OAP server in the default namespace:
+
+```sh
+curl https://raw.githubusercontent.com/apache/skywalking-swck/master/config/samples/oap.yaml | kubectl apply -f -
+```
+
+2. Check the OAP server in Kubernetes:
+
+```sh
+kubectl get oapserver
+```
+
+## Troubleshooting
+
+If you encounter any issue, you can check the log of the controller by pulling it from Kubernetes:
+
+```sh
+# get the pod name of your controller
+kubectl --namespace skywalking-swck-system get pods
+
+# pull the logs
+kubectl --namespace skywalking-swck-system logs -f [name_of_the_controller_pod]
+```
+
+# Contributing
+For developers who want to contribute to this project, see [Contribution Guide](CONTRIBUTING.md)
Review comment:
CONTRIBUTING.md contains part indicates how to raise an issue in the main repo, for example, "How to report a bug".
I composed it with reference to cli's contributing, would you pls show me other examples?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723439886
@hanahmily I found two problems.
1. The `manager-role` cannot read the services
```
E1107 12:14:26.309147 1 reflector.go:153] pkg/mod/k8s.io/client-go@v0.17.2/tools/cache/reflector.go:105: Failed to list *v1.Service: services is forbidden: User "system:serviceaccount:skywalking-swck-system:default" cannot list resource "services" in API group "" at the cluster scope
```
2. `kustomize` cannot modify the name of `namesapce`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723428738
@arugal As you have tested and tried locally, could do take a look of current status?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723465595
> @hanahmily Why these files were not detected by your script? This seems more important.
Licenses tool only checks files in the config directory, that are updated from time to time. These files are imported, but they won't be changed once fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519074510
##########
File path: README.md
##########
@@ -1,3 +1,77 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+ 1. Create the `skywalking-swck-system` namespace:
+ ```
+ kubectl create namespace skywalking-swck-system
+ ```
+ 1. Apply the manifests for the Controller and CRDs in release/config:
+ ```
+ kubectl apply -f release/config
+ ```
+
+# Guides of Deployment
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone git@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/default/kustomization.yaml` file to change your preferences. If you prefer to your private docker image, a quick path to override `IMG` environment variable : `export IMG=<private registry>/controller:<tag>`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make deploy
+```
+
+4. Deploy the CRDs:
+
+```sh
+make install
+```
+
+## Test your deployment
+
+1. Deploy a sample OAP server, this will create a OAP server in the default namespace:
+
+```sh
+curl https://raw.githubusercontent.com/apache/skywalking-swck/master/config/samples/oap.yaml | kubectl apply -f -
+```
+
+2. Check the OAP server in Kubernetes:
+
+```sh
+kubectl get oapserver
+```
+
+## Troubleshooting
+
+If you encounter any issue, you can check the log of the controller by pulling it from Kubernetes:
+
+```sh
+# get the pod name of your controller
+kubectl --namespace skywalking-swck-system get pods
+
+# pull the logs
+kubectl --namespace skywalking-swck-system logs -f [name_of_the_controller_pod]
+```
+
+# Contributing
+For developers who want to contribute to this project, see [Contribution Guide](CONTRIBUTING.md)
Review comment:
Add the issue part of the contributing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723519207
> > > We can set namespace by `cd config/default && kustomize edit set namespace <new ns>` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.
> >
> >
> > The [namespace parameter](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/default/kustomization.yaml#L19) is not valid for [namespace resource](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/manager/manager.yaml#L18-L23).
> > I think that's the way it should be.
> > ```yaml
> > apiVersion: v1
> > kind: Namespace
> > metadata:
> > labels:
> > control-plane: controller-manager
> > name: skywalking-swck-system
> > ```
>
> My local kustomize could generate correct namespace:
>
> ```shell
> $ kustomize version
> {Version:3.5.4 GitCommit:3af514fa9f85430f0c1557c4a0291e62112ab026 BuildDate:2020-01-17T14:23:25+00:00 GoOs:darwin GoArch:amd64}
> $ kustomize build config/default
> apiVersion: v1
> kind: Namespace
> metadata:
> labels:
> control-plane: controller-manager
> name: skywalking-swck-system
> ```
>
> I'm curious about which version your kusomize is?
>
> and my kubectl also could get the same result:
>
> ```
> $ kubectl version --client
> Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.1", GitCommit:"7879fc12a63337efff607952a323df90cdc7a335", GitTreeState:"clean", BuildDate:"2020-04-10T21:53:51Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}
> $ kubectl kustomize config/default
> apiVersion: v1
> kind: Namespace
> metadata:
> labels:
> control-plane: controller-manager
> name: skywalking-swck-system
> ---
> ```
@hanahmily Sorry, I have tested kustomize 3.8.1-3.8.4 locally and this seems to be the case only at 3.8.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723426430
@wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal edited a comment on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal edited a comment on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723532402
Basically LGTM.
```bash
$ kubectl get all -n skywalking-swck-system
NAME READY STATUS RESTARTS AGE
pod/skywalking-swck-controller-manager-6989f8cf96-gdjjp 2/2 Running 0 3h17m
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/skywalking-swck-controller-manager-metrics-service ClusterIP 10.111.142.191 <none> 8443/TCP 3h20m
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/skywalking-swck-controller-manager 1/1 1 1 3h20m
NAME DESIRED CURRENT READY AGE
replicaset.apps/skywalking-swck-controller-manager-557bdff78f 0 0 0 3h20m
replicaset.apps/skywalking-swck-controller-manager-6989f8cf96 1 1 1 3h17m
$ kubectl get oapserver demo -o yaml
apiVersion: operator.skywalking.apache.org/v1alpha1
kind: OAPServer
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"operator.skywalking.apache.org/v1alpha1","kind":"OAPServer","metadata":{"annotations":{},"name":"demo","namespace":"default"},"spec":{"config":[{"name":"SW_STORAGE","value":"h2"}],"instances":1,"version":"8.1.0"}}
creationTimestamp: "2020-11-08T02:01:36Z"
generation: 2
name: demo
namespace: default
resourceVersion: "33314335"
selfLink: /apis/operator.skywalking.apache.org/v1alpha1/namespaces/default/oapservers/demo
uid: 490b4496-0a9c-4a33-80e8-1f3e5ba864af
spec:
config:
- name: SW_STORAGE
value: h2
image: apache/skywalking-oap-server:8.1.0-es6
instances: 1
version: 8.1.0
status:
address: demo.default
availableReplicas: 1
conditions:
- lastTransitionTime: "2020-11-08T02:02:51Z"
lastUpdateTime: "2020-11-08T02:02:51Z"
message: Deployment has minimum availability.
reason: MinimumReplicasAvailable
status: "True"
type: Available
- lastTransitionTime: "2020-11-08T02:01:36Z"
lastUpdateTime: "2020-11-08T02:02:51Z"
message: ReplicaSet "demo-5d6bbbbf94" has successfully progressed.
reason: NewReplicaSetAvailable
status: "True"
type: Progressing
$ kubectl get all
NAME READY STATUS RESTARTS AGE
pod/demo-5d6bbbbf94-hq879 1/1 Running 0 3h19m
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/demo ClusterIP 10.104.216.11 <none> 11800/TCP,12800/TCP 3h19m
service/kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 126d
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/demo 1/1 1 1 3h19m
NAME DESIRED CURRENT READY AGE
replicaset.apps/demo-5d6bbbbf94 1 1 1 3h19m
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723466498
> > We can set namespace by `cd config/default && kustomize edit set namespace <new ns>` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.
>
> The [namespace parameter](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/default/kustomization.yaml#L19) is not valid for [namespace resource](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/manager/manager.yaml#L18-L23).
>
> I think that's the way it should be.
>
> ```yaml
> apiVersion: v1
> kind: Namespace
> metadata:
> labels:
> control-plane: controller-manager
> name: skywalking-swck-system
> ```
My local kustomize could generate correct namespace:
```shell
$ kustomize version
{Version:3.5.4 GitCommit:3af514fa9f85430f0c1557c4a0291e62112ab026 BuildDate:2020-01-17T14:23:25+00:00 GoOs:darwin GoArch:amd64}
$ kustomize build config/default
apiVersion: v1
kind: Namespace
metadata:
labels:
control-plane: controller-manager
name: skywalking-swck-system
```
I'm curious about which version your kusomize is?
and my kubectl also could get the same result:
```
$ kubectl version --client
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.1", GitCommit:"7879fc12a63337efff607952a323df90cdc7a335", GitTreeState:"clean", BuildDate:"2020-04-10T21:53:51Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}
$ kubectl kustomize config/default
apiVersion: v1
kind: Namespace
metadata:
labels:
control-plane: controller-manager
name: skywalking-swck-system
---
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519257523
##########
File path: README.md
##########
@@ -1,3 +1,78 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+
+ 2. Create the `skywalking-swck-system` namespace:
Review comment:
`kustomize build config/default > ${bindir}/config/deploy.yaml` contains create`namespace`, I think we can skip this step :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519260908
##########
File path: README.md
##########
@@ -1,3 +1,78 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+
+ 2. Create the `skywalking-swck-system` namespace:
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723450333
> > @wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.
>
> If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.
Could you list what files are you talking about?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723459638
> 1. `kustomize` cannot modify the name of `namesapce`
> 
> 
We can set namespace by `cd config/default && kustomize edit set namespace <new ns>` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723532402
Basically LGTM.
```bash
$ kubectl get all -n skywalking-swck-system
NAME READY STATUS RESTARTS AGE
pod/skywalking-swck-controller-manager-6989f8cf96-gdjjp 2/2 Running 0 3h17m
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/skywalking-swck-controller-manager-metrics-service ClusterIP 10.111.142.191 <none> 8443/TCP 3h20m
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/skywalking-swck-controller-manager 1/1 1 1 3h20m
NAME DESIRED CURRENT READY AGE
replicaset.apps/skywalking-swck-controller-manager-557bdff78f 0 0 0 3h20m
replicaset.apps/skywalking-swck-controller-manager-6989f8cf96 1 1 1 3h17m
$ kubectl get oapserver demo -o yaml
apiVersion: operator.skywalking.apache.org/v1alpha1
kind: OAPServer
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"operator.skywalking.apache.org/v1alpha1","kind":"OAPServer","metadata":{"annotations":{},"name":"demo","namespace":"default"},"spec":{"config":[{"name":"SW_STORAGE","value":"h2"}],"instances":1,"version":"8.1.0"}}
creationTimestamp: "2020-11-08T02:01:36Z"
generation: 2
name: demo
namespace: default
resourceVersion: "33314335"
selfLink: /apis/operator.skywalking.apache.org/v1alpha1/namespaces/default/oapservers/demo
uid: 490b4496-0a9c-4a33-80e8-1f3e5ba864af
spec:
config:
- name: SW_STORAGE
value: h2
image: apache/skywalking-oap-server:8.1.0-es6
instances: 1
version: 8.1.0
status:
address: demo.default
availableReplicas: 1
conditions:
- lastTransitionTime: "2020-11-08T02:02:51Z"
lastUpdateTime: "2020-11-08T02:02:51Z"
message: Deployment has minimum availability.
reason: MinimumReplicasAvailable
status: "True"
type: Available
- lastTransitionTime: "2020-11-08T02:01:36Z"
lastUpdateTime: "2020-11-08T02:02:51Z"
message: ReplicaSet "demo-5d6bbbbf94" has successfully progressed.
reason: NewReplicaSetAvailable
status: "True"
type: Progressing
$ kubect get all
NAME READY STATUS RESTARTS AGE
pod/demo-5d6bbbbf94-hq879 1/1 Running 0 3h19m
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/demo ClusterIP 10.104.216.11 <none> 11800/TCP,12800/TCP 3h19m
service/kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 126d
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/demo 1/1 1 1 3h19m
NAME DESIRED CURRENT READY AGE
replicaset.apps/demo-5d6bbbbf94 1 1 1 3h19m
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519158088
##########
File path: README.md
##########
@@ -1,3 +1,77 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+ 1. Create the `skywalking-swck-system` namespace:
+ ```
Review comment:
> BTW, I think the namespace is kinda of long, and verbose, because swck contains “skywalking” already :)
It's from the repo's name, as a subproject, swck needs a prefix of the main project. and my preference is to keep it as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng merged pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723461420
@hanahmily Why these files were not detected by your script? This seems more important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723462359
> We can set namespace by `cd config/default && kustomize edit set namespace <new ns>` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.
The [namespace parameter](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/default/kustomization.yaml#L19) is not valid for [namespace resource](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/manager/manager.yaml#L18-L23).
This is what I expect:
```yaml
apiVersion: v1
kind: Namespace
metadata:
labels:
control-plane: controller-manager
name: skywalking-swck-system
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] kezhenxu94 commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723447860
> @wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.
If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723366369
@kezhenxu94 Consider adding reviewer and CI required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519162779
##########
File path: README.md
##########
@@ -1,3 +1,77 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+ 1. Create the `skywalking-swck-system` namespace:
+ ```
+ kubectl create namespace skywalking-swck-system
+ ```
+ 1. Apply the manifests for the Controller and CRDs in release/config:
+ ```
+ kubectl apply -f release/config
+ ```
+
+# Guides of Deployment
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone git@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/default/kustomization.yaml` file to change your preferences. If you prefer to your private docker image, a quick path to override `IMG` environment variable : `export IMG=<private registry>/controller:<tag>`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make deploy
+```
+
+4. Deploy the CRDs:
+
+```sh
+make install
+```
+
+## Test your deployment
+
+1. Deploy a sample OAP server, this will create a OAP server in the default namespace:
+
+```sh
+curl https://raw.githubusercontent.com/apache/skywalking-swck/master/config/samples/oap.yaml | kubectl apply -f -
+```
+
+2. Check the OAP server in Kubernetes:
+
+```sh
+kubectl get oapserver
+```
+
+## Troubleshooting
+
+If you encounter any issue, you can check the log of the controller by pulling it from Kubernetes:
+
+```sh
+# get the pod name of your controller
+kubectl --namespace skywalking-swck-system get pods
+
+# pull the logs
+kubectl --namespace skywalking-swck-system logs -f [name_of_the_controller_pod]
+```
+
+# Contributing
+For developers who want to contribute to this project, see [Contribution Guide](CONTRIBUTING.md)
Review comment:
OK, should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] kezhenxu94 commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519078950
##########
File path: README.md
##########
@@ -1,3 +1,77 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+ 1. Create the `skywalking-swck-system` namespace:
+ ```
Review comment:
Click the review button, seems the list order is incorrect, maybe giving the code block some indents fixes it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519176922
##########
File path: README.md
##########
@@ -1,3 +1,78 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+============
+
+
+
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+A bridge project between [Apache SkyWalking](https://github.com/apache/skywalking) and Kubernetes.
+
+SWCK is a platform for the SkyWalking user, provisions, upgrades, maintains SkyWalking relevant components, and makes them work natively on Kubernetes.
+
+# Quick Start
+
+ 1. Go to the [download page](https://skywalking.apache.org/downloads/) to download latest release manifest.
+
+ 2. Create the `skywalking-swck-system` namespace:
+ ```
+ kubectl create namespace skywalking-swck-system
+ ```
+ 3. Apply the manifests for the Controller and CRDs in release/config:
+ ```
+ kubectl apply -f release/config
+ ```
+
+# Guides of Deployment
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone git@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/default/kustomization.yaml` file to change your preferences. If you prefer to your private docker image, a quick path to override `IMG` environment variable : `export IMG=<private registry>/controller:<tag>`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make deploy
Review comment:
Due to network reasons, `gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1` may fail to pull, please add tips.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal commented on a change in pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519244934
##########
File path: controllers/oapserver_controller.go
##########
@@ -52,6 +52,7 @@ type OAPServerReconciler struct {
// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=oapservers,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=oapservers/status,verbs=get;update;patch
// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
+// +kubebuilder:rbac:groups=,resources=services,verbs=get;list;watch;create;update;patch;delete
Review comment:
```suggestion
// +kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
```
Need to specify group.
```
The ClusterRole "skywalking-swck-manager-role" is invalid: rules[0].apiGroups: Required value: resource rules must supply at least one api group
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] arugal edited a comment on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
arugal edited a comment on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723462359
> We can set namespace by `cd config/default && kustomize edit set namespace <new ns>` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.
The [namespace parameter](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/default/kustomization.yaml#L19) is not valid for [namespace resource](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/manager/manager.yaml#L18-L23).
I think that's the way it should be.
```yaml
apiVersion: v1
kind: Namespace
metadata:
labels:
control-plane: controller-manager
name: skywalking-swck-system
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] kezhenxu94 commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723451480
> > > @wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.
> >
> >
> > If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.
>
> Could you list what files are you talking about?
https://github.com/apache/skywalking-swck/blob/master/golangci.yml
https://github.com/apache/skywalking-swck/blob/master/Dockerfile
https://github.com/apache/skywalking-swck/blob/master/PROJECT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723460742
> > > > @wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.
> > >
> > >
> > > If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.
> >
> >
> > Could you list what files are you talking about?
>
> https://github.com/apache/skywalking-swck/blob/master/golangci.yml
> https://github.com/apache/skywalking-swck/blob/master/Dockerfile
> https://github.com/apache/skywalking-swck/blob/master/PROJECT
Thanks, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org