[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #415: Network Monitor: Runtime selection of DHCP/Static IP with fall back set by fsutil/ipcfg and a polled mode for HW lacking a PHY interrupt

[GitBox <gi...@apache.org>]

davids5 commented on pull request #415:
URL: https://github.com/apache/incubator-nuttx-apps/pull/415#issuecomment-702612356


   > > Let's do the thing right and correctly, I don't think this feature is so critical to rush into 10.0 release timeframe. It's better to get IPv6 support and then release in 10.1.
   > 
   > @xiaoxiang781216 I disagree. As long as there isn't anything wrong with these IPv4 changes, and it doesn't break or change anything that worked before for IPv6, then we should merge it.
   
   This PR is to the benefit IPv4.  There is nothing wrong or incorrect other than it does not solve your desire for IPv6.  In fact, it can be totally turned off.
   
   I suggest you merge this PR as it stands now. You can then take over the IPv6 work. I do not have a use case (in ASF terms. it is not my ITCH) for it nor am I set up to test IPv6. 
   
   All I ask is you do not break the IPv4 functionality as it solves a problem with multi system disparate boot times. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org