You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/24 19:44:28 UTC
[GitHub] [nifi] tt0suzy opened a new pull request, #6718: NIFI-10875 fixed flaky test
tt0suzy opened a new pull request, #6718:
URL: https://github.com/apache/nifi/pull/6718
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10875](https://issues.apache.org/jira/browse/NIFI-10875)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tt0suzy commented on pull request #6718: NIFI-10875 fixed flaky test
Posted by GitBox <gi...@apache.org>.
tt0suzy commented on PR #6718:
URL: https://github.com/apache/nifi/pull/6718#issuecomment-1329627562
Hi @exceptionfactory, are you suggesting something like
```
String querySrting = attributes.get(QuerySolr.ATTRIBUTE_SOLR_QUERY)
//"q=*:*&qt=/select&start=0&rows=10&stats=true&facet=true"
assertTrue(queryString.contains("q=*:*") && queryString.contains("qt=/select") && querystring.contains("start=0") && queryString.contains("rows=10") && queryString.contains("stats=true") && queryString.contains("facet=true"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6718: NIFI-10875 fixed flaky test
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6718:
URL: https://github.com/apache/nifi/pull/6718#discussion_r1034050671
##########
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/test/java/org/apache/nifi/processors/solr/TestQuerySolr.java:
##########
@@ -588,7 +588,7 @@ public void testAttributes() {
MockFlowFile flowFile = runner.getFlowFilesForRelationship(QuerySolr.RESULTS).get(0);
Map<String, String> attributes = flowFile.getAttributes();
-
+
Review Comment:
The checkstyle static analysis flagged this line change as a warning, so it needs to be removed:
Warning: src/test/java/org/apache/nifi/processors/solr/TestQuerySolr.java:[591] (regexp) RegexpSinglelineJava: Line has trailing whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tt0suzy commented on pull request #6718: NIFI-10875 fixed flaky test
Posted by GitBox <gi...@apache.org>.
tt0suzy commented on PR #6718:
URL: https://github.com/apache/nifi/pull/6718#issuecomment-1329664299
Updated, thanks for the advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6718: NIFI-10875 fixed flaky test
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6718: NIFI-10875 fixed flaky test
URL: https://github.com/apache/nifi/pull/6718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6718: NIFI-10875 fixed flaky test
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6718:
URL: https://github.com/apache/nifi/pull/6718#issuecomment-1329640686
> Hi @exceptionfactory, are you suggesting something like
>
> ```
> String querySrting = attributes.get(QuerySolr.ATTRIBUTE_SOLR_QUERY)
> //"q=*:*&qt=/select&start=0&rows=10&stats=true&facet=true"
> assertTrue(queryString.contains("q=*:*") && queryString.contains("qt=/select") && querystring.contains("start=0") && queryString.contains("rows=10") && queryString.contains("stats=true") && queryString.contains("facet=true"));
> ```
Thanks for the reply @tt0suzy. Yes, that is the basic idea. Instead of multiple `queryString.contains()` calls with in one `assertTrue`. Having one assert per check would be helpful to keep the code clear:
```
assertTrue(queryString.contains("q=*:*"));
assertTrue(queryString.contains("qt=/select"));
...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6718: NIFI-10875 fixed flaky test
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6718:
URL: https://github.com/apache/nifi/pull/6718#issuecomment-1329462642
Thanks for the contribution @tt0suzy. Instead of changing the test to use the inline conditional, a better approach would be to assert the presence of the individual key=value parameters. That would avoid depending on parameter order while keeping the test clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org