You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/03 10:52:18 UTC
[GitHub] [airflow] kaxil commented on a change in pull request #6715:
[AIRFLOW-5945] Make inbuilt OperatorLinks work when using Serialization
kaxil commented on a change in pull request #6715: [AIRFLOW-5945] Make inbuilt OperatorLinks work when using Serialization
URL: https://github.com/apache/airflow/pull/6715#discussion_r353108771
##########
File path: airflow/contrib/operators/qubole_operator.py
##########
@@ -240,3 +241,9 @@ def __setattr__(self, name, value):
self.kwargs[name] = value
else:
object.__setattr__(self, name, value)
+
+ @classmethod
+ def get_serialized_fields(cls):
+ """Serialized QuboleOperator contain exactly these fields."""
+ cls._serialized_fields = frozenset(super().get_serialized_fields() | {"qubole_conn_id"})
Review comment:
The problem is when calling `super().get_serialized_fields()` it would set `cls._serialized_fields` from the BaseOperator, hence it would not have `{"sql"}` in it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services