You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DrIgor <gi...@git.apache.org> on 2016/12/29 10:38:40 UTC
[GitHub] zeppelin pull request #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInt...
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1819
[ZEPPELIN-914] Apply new mechanism to IgniteInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-914](https://issues.apache.org/jira/browse/ZEPPELIN-914)
### How should this be tested?
There shouldn't be any warning like below on starting the server
```
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json
INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
```
And ensure that the Ignite related paragraphs run without any error
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1819.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1819
----
commit c1b5bb4745de9eb0a6a2c93d741c660d6397cff1
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit d140d9ce56a342b1a6b23e2cebc3fdd83a725417
Author: Igor Drozdov <ig...@epam.com>
Date: 2016-12-28T09:47:13Z
Fixed typo in default value and description
commit ddba11a43c5c8159e922ab149ed4a88f8ad4bfd6
Author: Igor Drozdov <ig...@epam.com>
Date: 2016-12-28T11:28:19Z
Add missing property to make test green
Default value is set in `interpreter-setting.json` but test doesn't use this file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInterprete...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1819
Thanks!! LGTM. Will merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInterprete...
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1819
Original pull request #1561
IgniteSqlInterpreterTest is known flaky test: [ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInterprete...
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1819
Travis fails with:
```
testBasicIntp(org.apache.zeppelin.spark.PySparkInterpreterTest) Time elapsed: 58.947 sec <<< FAILURE!
java.lang.AssertionError: expected:<SUCCESS> but was:<ERROR>
```
Known issue: [ZEPPELIN-1746](https://issues.apache.org/jira/browse/ZEPPELIN-1746)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1819
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---