You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/18 03:31:24 UTC

Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/
-----------------------------------------------------------

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
-------

CMake: Fixed Find* scripts to not explode if invoked twice.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
  3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake c975a16975e76b38f028d7575775abd31c9090f5 

Diff: https://reviews.apache.org/r/43700/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/#review121348
-----------------------------------------------------------


Ship it!




- Joris Van Remoortere


On Feb. 18, 2016, 2:31 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43700/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Fixed Find* scripts to not explode if invoked twice.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake c975a16975e76b38f028d7575775abd31c9090f5 
> 
> Diff: https://reviews.apache.org/r/43700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

Posted by Yi Sun <yi...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/#review119645
-----------------------------------------------------------


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:31 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43700/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Fixed Find* scripts to not explode if invoked twice.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake c975a16975e76b38f028d7575775abd31c9090f5 
> 
> Diff: https://reviews.apache.org/r/43700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/#review119947
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Naparu


On Feb. 18, 2016, 2:31 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43700/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Fixed Find* scripts to not explode if invoked twice.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake c975a16975e76b38f028d7575775abd31c9090f5 
> 
> Diff: https://reviews.apache.org/r/43700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>