You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by "Robert S. Sfeir" <ro...@codepuccino.com> on 2004/04/15 23:12:00 UTC
[PATCH] Final Modifier
Finally have more time on my hands, so I ran through the IDEA code
inspector and changed all the places where the final modifier could be
added. This was only done to method params and variables, not classes
or methods themselves. I ran the patches on the src/java directory only.
The document is at:
http://www.codepuccino.com/patches/finalmodifier.txt
(It's 1.1MB, but I've take great care this time to only show the changes
in the diff)
I've run my local compile and junit tests, and as I mentioned to Brian
in a separate email, the tests ran faster and memory usage was lower
over all.
There are also about 74 different spots in the src/java directory where
either of those conditions exist:
1- Possible runtime exceptions are not caught, notably some
NullPointerExceptions with no try catch block
2- conditions which are always true or false.
Is there interest in me going through and whacking those out and
submitting a patch, or would you prefer a report (in html) of where
these places are so you can go and fix them at your leisure, or do you
simply not care :-) ?
Thanks
R
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: [PATCH] Final Modifier
Posted by Robert Sfeir <ro...@codepuccino.com>.
Sweet! Thanks Brian.
Yeah this is one long monster sorry :-\
R
On Apr 17, 2004, at 7:08 PM, Brian McCallister wrote:
> I am working on applying his patch. It is a long process as patch is,
> despite being absurdly flexible, realy stupid when it comes to doing
> things in dirs.
>
> -Brian
>
> On Apr 17, 2004, at 12:37 PM, Armin Waibel wrote:
>
>> Hi Robert,
>>
>> thanks for your effort. Currently I'm very busy with other stuff, e.g.
>> reformat docu-xml files for use within Forrest and try to implement a
>> prototype of the feature you suggested some weeks ago (Reference
>> metadata changes at runtime - do you remember?).
>> Maybe some of the other developers find the time to apply your
>> patch. At the latest after the 1.0 we will find the time for code
>> optimisation ;-)
>>
>> regards,
>> Armin
>>
>> Robert S. Sfeir wrote:
>>
>>> Finally have more time on my hands, so I ran through the IDEA code
>>> inspector and changed all the places where the final modifier could
>>> be added. This was only done to method params and variables, not
>>> classes or methods themselves. I ran the patches on the src/java
>>> directory only.
>>> The document is at:
>>> http://www.codepuccino.com/patches/finalmodifier.txt
>>> (It's 1.1MB, but I've take great care this time to only show the
>>> changes in the diff)
>>> I've run my local compile and junit tests, and as I mentioned to
>>> Brian in a separate email, the tests ran faster and memory usage was
>>> lower over all.
>>> There are also about 74 different spots in the src/java directory
>>> where either of those conditions exist:
>>> 1- Possible runtime exceptions are not caught, notably some
>>> NullPointerExceptions with no try catch block
>>> 2- conditions which are always true or false.
>>> Is there interest in me going through and whacking those out and
>>> submitting a patch, or would you prefer a report (in html) of where
>>> these places are so you can go and fix them at your leisure, or do
>>> you simply not care :-) ?
>>> Thanks
>>> R
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>>
>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: [PATCH] Final Modifier
Posted by Brian McCallister <mc...@forthillcompany.com>.
I am working on applying his patch. It is a long process as patch is,
despite being absurdly flexible, realy stupid when it comes to doing
things in dirs.
-Brian
On Apr 17, 2004, at 12:37 PM, Armin Waibel wrote:
> Hi Robert,
>
> thanks for your effort. Currently I'm very busy with other stuff, e.g.
> reformat docu-xml files for use within Forrest and try to implement a
> prototype of the feature you suggested some weeks ago (Reference
> metadata changes at runtime - do you remember?).
> Maybe some of the other developers find the time to apply your patch.
> At the latest after the 1.0 we will find the time for code
> optimisation ;-)
>
> regards,
> Armin
>
> Robert S. Sfeir wrote:
>
>> Finally have more time on my hands, so I ran through the IDEA code
>> inspector and changed all the places where the final modifier could
>> be added. This was only done to method params and variables, not
>> classes or methods themselves. I ran the patches on the src/java
>> directory only.
>> The document is at:
>> http://www.codepuccino.com/patches/finalmodifier.txt
>> (It's 1.1MB, but I've take great care this time to only show the
>> changes in the diff)
>> I've run my local compile and junit tests, and as I mentioned to
>> Brian in a separate email, the tests ran faster and memory usage was
>> lower over all.
>> There are also about 74 different spots in the src/java directory
>> where either of those conditions exist:
>> 1- Possible runtime exceptions are not caught, notably some
>> NullPointerExceptions with no try catch block
>> 2- conditions which are always true or false.
>> Is there interest in me going through and whacking those out and
>> submitting a patch, or would you prefer a report (in html) of where
>> these places are so you can go and fix them at your leisure, or do
>> you simply not care :-) ?
>> Thanks
>> R
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: [PATCH] Final Modifier
Posted by Armin Waibel <ar...@apache.org>.
Hi Robert,
thanks for your effort. Currently I'm very busy with other stuff, e.g.
reformat docu-xml files for use within Forrest and try to implement a
prototype of the feature you suggested some weeks ago (Reference
metadata changes at runtime - do you remember?).
Maybe some of the other developers find the time to apply your patch.
At the latest after the 1.0 we will find the time for code optimisation ;-)
regards,
Armin
Robert S. Sfeir wrote:
> Finally have more time on my hands, so I ran through the IDEA code
> inspector and changed all the places where the final modifier could be
> added. This was only done to method params and variables, not classes
> or methods themselves. I ran the patches on the src/java directory only.
>
> The document is at:
>
> http://www.codepuccino.com/patches/finalmodifier.txt
> (It's 1.1MB, but I've take great care this time to only show the changes
> in the diff)
>
> I've run my local compile and junit tests, and as I mentioned to Brian
> in a separate email, the tests ran faster and memory usage was lower
> over all.
>
> There are also about 74 different spots in the src/java directory where
> either of those conditions exist:
>
> 1- Possible runtime exceptions are not caught, notably some
> NullPointerExceptions with no try catch block
>
> 2- conditions which are always true or false.
>
> Is there interest in me going through and whacking those out and
> submitting a patch, or would you prefer a report (in html) of where
> these places are so you can go and fix them at your leisure, or do you
> simply not care :-) ?
>
> Thanks
>
> R
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org