You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/02/08 23:40:26 UTC

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole() 

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9261

to review the following change.


Change subject: cmeta: Use more efficient form of GetConsensusRole()
......................................................................

cmeta: Use more efficient form of GetConsensusRole()

Now that there is a form of GetConsensusRole() that can be called
without instantiating an instance of ConsensusStatePB, which requires a
bunch of string copies, let's use that for
ConsensusMetadata::UpdateActiveRole() instead.

Change-Id: Ia192d75ffef614e2c1832df85c1332cb13d49f39
---
M src/kudu/consensus/consensus_meta.cc
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/9261/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia192d75ffef614e2c1832df85c1332cb13d49f39
Gerrit-Change-Number: 9261
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9261 )

Change subject: cmeta: Use more efficient form of GetConsensusRole()
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia192d75ffef614e2c1832df85c1332cb13d49f39
Gerrit-Change-Number: 9261
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 10 Feb 2018 02:33:51 +0000
Gerrit-HasComments: No

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9261 )

Change subject: cmeta: Use more efficient form of GetConsensusRole()
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia192d75ffef614e2c1832df85c1332cb13d49f39
Gerrit-Change-Number: 9261
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 09 Feb 2018 05:03:59 +0000
Gerrit-HasComments: No

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole()

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9261 )

Change subject: cmeta: Use more efficient form of GetConsensusRole()
......................................................................

cmeta: Use more efficient form of GetConsensusRole()

Now that there is a form of GetConsensusRole() that can be called
without instantiating an instance of ConsensusStatePB, which requires a
bunch of string copies, let's use that for
ConsensusMetadata::UpdateActiveRole() instead.

Change-Id: Ia192d75ffef614e2c1832df85c1332cb13d49f39
Reviewed-on: http://gerrit.cloudera.org:8080/9261
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/consensus_meta.cc
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia192d75ffef614e2c1832df85c1332cb13d49f39
Gerrit-Change-Number: 9261
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>